JuliaTesting / Aqua.jl

Auto QUality Assurance for Julia packages
MIT License
339 stars 25 forks source link

Add kwarg `succeed_on_precompilable_error` #285

Closed lgoettgens closed 6 months ago

lgoettgens commented 6 months ago

I often experience precompilable errors in development when sorting out type piracy etc., e.g. when moving functions to a dependency and thus creating method overwriting. This change let's the persistent task test succeed in the case of a precompilable error to smooth these cases, with the possibility to opt-in into getting this as a failure instead.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.14%. Comparing base (ee2d9a8) to head (08a9f4b). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #285 +/- ## ========================================== - Coverage 75.03% 70.14% -4.89% ========================================== Files 11 11 Lines 761 757 -4 ========================================== - Hits 571 531 -40 - Misses 190 226 +36 ``` | [Flag](https://app.codecov.io/gh/JuliaTesting/Aqua.jl/pull/285/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/JuliaTesting/Aqua.jl/pull/285/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting) | `70.14% <100.00%> (-4.89%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaTesting#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.