Closed Julian closed 9 months ago
These are all quite minor I think, and mostly was a way to just poke at your code. Will give it a fresh look in the morning before merging, but @hargoniX if you have any comments feel free to lemme know!
I meant to check if Loogle ever returns names with newlines for any absurdly long one. Hopefully not but leaving a just in case note to check.
No I don't think it should do that but @nomeata should probably know the details on that? I'm a little surprised about the types with newlines as well, can you comment on that Joachim?
Apart from that I believe the changes look fine.
I'm using some delaborator that I found, but plan to refine that anyways (more concise syntax where possible, maybe omitting some types or names…), I can try to avoid newlines then. but better be defensive - s/\n/ /
doesn't hurt
Thanks both!
put
charwise, so that e.g. #checkrequire'lean.loogle'.search()
, which simply returns resultsThere's probably a few small other things that can be tidied.