Getting installed.toml with [ [ "t", "w", "i", ......

Julian / venvs

venvs creates virtualenvs

https://pypi.org/project/venvs/

MIT License

17 stars 12 forks source link

Getting installed.toml with [ [ "t", "w", "i", ...... #92

Closed altendky closed 4 years ago

altendky commented 4 years ago

Can you guess what it ought to be? (PR to follow at least for a test for this) I tried to recreate but even when I make a dict that's == to the config to be dumped... toml.dumps() messes up the venvs-created dict and not my manually created dict.

install = [ [ "t", "w", "i", "n", "e",],]
requirements = []
link = [ [ "t", "w", "i", "n", "e",],]
link-module = []
python = "/home/altendky/repos/venvs/venv/bin/python"
"sys.version" = "Python 3.8.0\n"

altendky commented 4 years ago

So far every time I've set a breakpoint at the end of the snippet below I've seen the issue in the result of toml.dumps(config).

https://github.com/Julian/venvs/blob/5643867e9ad0f25390ad1aaf1f18a23f361deda7/venvs/converge.py#L53-L63

I don't know why my PyCharm console isn't working but... here's an image at least of my confused 'equal but dump differently' dicts.

Julian commented 4 years ago

After 1ddb188e5bf0eae33ea9a527f6e699e758bd87db the code handling reading/writing this file basically has to be rewritten.

Certainly good to know though if it has a bug already.

Julian commented 4 years ago

OK, I made the change to JSON on master (and will release in a second), so give this another shot and lemme know.