search

JulianAssmann / flutter_background

A flutter plugin to keep apps running in the background via foreground services. Android only.
https://pub.dev/packages/flutter_background
MIT License
88 stars 51 forks source link

Add Service Type for IsolateHolderService #83

Closed validcube closed 2 months ago

validcube commented 7 months ago

Starting in Android 14, all foreground service must list at least one foreground service type for each service.

Without listing a service type, the system will raise SecurityException.

https://developer.android.com/about/versions/14/behavior-changes-14#fgs-types

axoroll7 commented 4 months ago

Hello @validcube , I have a suggestion. I am not affiliated with this project, and I never helped here.

Can you rewrite it to respect the general coding style of this project ? No semicolon for startForeground, and keep <manifest ..> the way it was written.

Maybe the author of this project will be more inclined to accept this pull request directly.

emersion commented 2 months ago

Ref https://github.com/JulianAssmann/flutter_background/pull/89

emersion commented 2 months ago

This PR has been superseded by #89, I believe.

validcube commented 2 months ago

This PR has been superseded by #89, I believe.

I honestly haven't thought about this at that time but your suggestion works better so I'll consider closing this PR – And thanks.