JunSuzukiJapan / atom-keyboard-macros-vim

MIT License
17 stars 7 forks source link

Uncaught TypeError: Cannot read property 'indexOf' of undefined #5

Closed expelledboy closed 8 years ago

expelledboy commented 8 years ago

Shortcuts dont work, so:

  1. Manually toggled macro recording from menu
  2. While doing anything while recording the macro I get the follow error

NOTE I am using vim-mode-plus.

Atom Version: 1.7.2 System: Mac OS X 10.10.5 Thrown From: atom-keyboard-macros-vim package, v0.1.3

Stack Trace

Uncaught TypeError: Cannot read property 'indexOf' of undefined

At /Users/anthony/.atom/packages/atom-keyboard-macros-vim/lib/atom-keyboard-macros-vim.coffee:102

TypeError: Cannot read property 'indexOf' of undefined
    at Object.module.exports.AtomKeyboardMacrosVim.keyboardEventHandler (/Users/anthony/.atom/packages/atom-keyboard-macros-vim/lib/atom-keyboard-macros-vim.coffee:102:19)

Commands

     -2:08.1.0 vim-mode-plus:move-to-previous-word (atom-text-editor.editor.vim-mode-plus.is-focused.normal-mode)
     -2:07.6.0 vim-mode-plus:activate-insert-mode (atom-text-editor.editor.vim-mode-plus.is-focused.normal-mode)
  2x -2:06.3.0 core:backspace (atom-text-editor.editor.vim-mode-plus.is-focused.insert-mode)
     -1:59.7.0 vim-mode-plus:activate-normal-mode (atom-text-editor.editor.vim-mode-plus.is-focused.insert-mode)
  2x -0:29.7.0 find-and-replace:toggle (atom-text-editor.editor.vim-mode-plus.normal-mode.is-focused)
     -0:29.7.0 atom-keyboard-macros:start_kbd_macro (atom-text-editor.editor.vim-mode-plus.normal-mode.is-focused)
     -0:26.3.0 vim-mode-plus:activate-insert-mode (atom-text-editor.editor.vim-mode-plus.normal-mode.is-focused)
     -0:24.2.0 vim-mode-plus:activate-normal-mode (atom-text-editor.editor.vim-mode-plus.is-focused.insert-mode)
     -0:19.8.0 atom-keyboard-macros:end_kbd_macro (atom-text-editor.editor.vim-mode-plus.is-focused.normal-mode)
     -0:14 atom-keyboard-macros:call_last_kbd_macro (atom-text-editor.editor.vim-mode-plus.is-focused.normal-mode)
     -0:14 vim-mode-plus:activate-insert-mode (atom-text-editor.editor.vim-mode-plus.is-focused.normal-mode)
     -0:14 vim-mode-plus:activate-normal-mode (atom-text-editor.editor.vim-mode-plus.is-focused.insert-mode)
  2x -0:07.2.0 find-and-replace:toggle (atom-text-editor.editor.vim-mode-plus.is-focused.normal-mode)
     -0:07.2.0 atom-keyboard-macros-vim:toggle_record_macro_vim (atom-text-editor.editor.vim-mode-plus.is-focused.normal-mode)
  8x -0:05.4.0 blur (atom-text-editor.editor.mini.is-focused)
     -0:00.8.0 vim-mode-plus:move-to-beginning-of-line (atom-text-editor.editor.vim-mode-plus.normal-mode.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "vim-surround",
      "ex-mode",
      "vim-mode",
      "vim-mode-visual-block",
      "vim-shift-movers"
    ]
  }
}

Installed Packages

# User
atom-elixir, v0.1.4
atom-keyboard-macros, v0.8.4
atom-keyboard-macros-vim, v0.1.3
autocomplete-paths, v1.0.2
editorconfig, v1.3.0
javascript-snippets, v1.2.1
jscs-snippets, v0.1.0
keyboard-scroll, v0.4.0
language-elixir, v0.12.3
language-erlang, v3.0.0
language-puppet, v0.19.1
linter, v1.11.4
linter-jscs, v3.5.0
linter-puppet, v1.0.0
local-history, v3.2.3
minimap, v4.22.1
react, v0.15.0
symbols-tree-view, v0.12.0
vim-mode-plus, v0.34.0

# Dev
No dev packages
expelledboy commented 8 years ago

Awesome! Got it working in vim-mode-plus with the bellow keymaps:

'atom-text-editor.vim-mode-plus:not(.insert-mode)':
    'q': 'atom-keyboard-macros-vim:toggle_record_macro_vim'
    '@': 'atom-keyboard-macros-vim:execute_macro_vim'

Thank you my friend!

Now I just need to figure out how to create a mapping to shift-q to execute @@ like the equivalent in vim nnoremap Q @@

expelledboy commented 8 years ago

I think this, and atom-keyboard-macros, should be merged into vim-mode-plus!

expelledboy commented 8 years ago

Even got my quick macro shortcut from vim to work, just with kemaps!

'atom-text-editor.vim-mode-plus:not(.insert-mode)':
    'q': 'atom-keyboard-macros-vim:toggle_record_macro_vim'
    '@': 'atom-keyboard-macros-vim:execute_macro_vim'
    'Q': 'atom-keyboard-macros:call_last_kbd_macro'
liam-ngy commented 8 years ago

@expelledboy Wow nice thanks

liam-ngy commented 8 years ago

Have the same error

sahil-a commented 8 years ago

Same error on vim-mode