search

JunoLab / atom-julia-client

Juno a good IDE?
http://junolab.org
MIT License
273 stars 72 forks source link

"toggle documentation" command doesn't close doc window #336

Open ssfrr opened 7 years ago

ssfrr commented 7 years ago

Running the "toggle documentation" command opens the documentation for whatever's under the cursor, but running it again doesn't close the docs.

pfitzseb commented 7 years ago

This is kinda by design (even though the command is misnamed then) -- do you actually want this to toggle or is it okay for you to use Esc to close the docs?

ssfrr commented 7 years ago

Ah, I see. I use the vim-mode-plus package which has a more-specific definition for escape that overrides Ink's, so I didn't realize there was a keybinding to close the boxes. I can just rebind locally. Feel free to close, or leave open as an issue to re-name that command.

smldis commented 7 years ago

Wait, a lot of people use vim-mode. Is it complicated to make toggle actually showing/hiding docs?

pfitzseb commented 7 years ago

Complicated? No, but I'm not sure about the correct behaviour here -- it seems annoying to me to have to ctrl-j ctrl-d twice to get docs for some other symbol on the same line. For now you can just rebind inline:clear-current to some other keybinding in your keymap.cson.

smldis commented 7 years ago

I don't use ctrl-j ctrl-d for docs I have already a faster keybinding provided as a default from the proton-mode package.. I can setup a custom keybinding for clearing the docs, but it would be awesome to me to have a way to either toggle them or clearing them automatically (by having just one doc message shown at a time). Now, this is probably more a feature request than an issue, so feel free to close if none else is interested

PetrKryslUCSD commented 6 years ago

The Esc key closes the latest documentation panel, but not any of the previous ones (if you've opened multiple).

PetrKryslUCSD commented 6 years ago

Actually, it sort of does close the previous ones. One just has to execute the "toggle documentation" for the already opened documentation. Then it can be closed with Esc.

pfitzseb commented 6 years ago

Oh, okay, that definitely is a bug. I'll have a look as soon as possible.

pfitzseb commented 6 years ago

Okay, I can't reproduce that behaviour. Note though that Esc is only supposed to close the docs on the current line.

PetrKryslUCSD commented 6 years ago

I checked this, and you're right, that behavior works.