search

Jupyter-Kale / kale

Jupyter Interactive Workflows for High Performance Computing
Other
15 stars 3 forks source link

Pre parsl #50

Closed OliverEvans96 closed 6 years ago

OliverEvans96 commented 6 years ago

These are changes I made before working on Parsl integration. I thought it would be good to break this up into two PRs. Hopefully I didn't break anything here.

OliverEvans96 commented 6 years ago

I agree that I was too quick to put everything in the source tree. I think some example .py files are useful as in ipyvolume examples, but notebooks and data for examples should be outside of the source tree. Would it be appropriate to deal with this as a separate PR after the Parsl stuff is merged to avoid excess rebasing?

Also, I agree that the environment config is an important and separate topic, as is logging.