search

JurajNyiri / HomeAssistant-Tapo-Control

Control for Tapo cameras as a Home Assistant component
Apache License 2.0
953 stars 80 forks source link

Password is shown in log #519

Closed yujinlin0224 closed 4 months ago

yujinlin0224 commented 4 months ago

Description

(Edit: image is removed)

Camera is using Tapo C125.

Reproduction Steps

After I cannot see the stream of camera in Home Assistant, I open the log to see what happened, I noticed camera reported 400 error and then I saw my password in my log.

Expected behavior

All passwords should be hiden in log.

If applicable, add error logs.

No response

Device Firmware

1.1.7 Build 231222 Rel. 64156n

Integration Version

5.4.14

Using stream component

Yes

Does camera work via official integrations?

Yes

Camera has all attributes filled out in developer tools

Yes

HASS Environment

Docker with WSL2 backend in Windows 11

Search for similar issues

Yes

Additional information

No response

JurajNyiri commented 4 months ago

RTSP requires password, in order to pass the stream to HA it needs to pass password as well.

These logs are not coming from this integration. I recommend opening ticket to HA.

JurajNyiri commented 4 months ago

Also the blur you used can be reversed. I recommend changing password and using solid color next time.

yujinlin0224 commented 4 months ago

OK, I will edit the post to remove the image and reopen the issue to HA. After I found this issue, I immediately changed the password with password generator.