search

Juris-M / jm-styles

Juris-M styles: extended CSL styles with jurisdiction support
67 stars 24 forks source link

Update Austrian and IBFD styles #9

Closed georgd closed 3 years ago

bwiernik commented 3 years ago

@georgd Is there someone you know other than Frank who could review these, at least for accuracy?

georgd commented 3 years ago

You mean syntactically? Unfortunately, no. I'm relying on constantly validating against the schema.

On checking for correct output, I'm working together with some legal scholars here, but they're all beginners with Jurism as I only began introducing it in Austria five months ago.

Brenton M. Wiernik @.***> schrieb am Do., 1. Apr. 2021, 16:57:

@georgd https://github.com/georgd Is there someone you know other than Frank who could review these, at least for accuracy?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Juris-M/jm-styles/pull/9#issuecomment-811965443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUH4WLOPHVRYUIAB2YWCTTGSCTZANCNFSM42FRF5OA .

bwiernik commented 3 years ago

No, I meant in terms of correct output. I can review for syntax/style, but don't have the knowledge to evaluate output.

georgd commented 3 years ago

I'll push the updated tests which I use for testing with citeproc-test-runner later today or tomorrow. They mainly are copied from the style manuals.

Brenton M. Wiernik @.***> schrieb am Do., 1. Apr. 2021, 17:51:

No, I meant in terms of correct output. I can review for syntax/style, but don't have the knowledge to evaluate output.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Juris-M/jm-styles/pull/9#issuecomment-812001557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUH4WTQGALHW2UEL64CQTTGSJBZANCNFSM42FRF5OA .

georgd commented 3 years ago

The style tests are updated in https://github.com/georgd/jm-style-tests/tree/jm-legcit, https://github.com/georgd/jm-style-tests/tree/jm-ibfd and https://github.com/georgd/jm-style-tests/tree/jmAzr (Some tests are failing for technical reasons, for others (UN.int case law), sources are ambiguous).

georgd commented 3 years ago

@bwiernik what do you propose for getting on with this?

bwiernik commented 3 years ago

This looks okay to me. Let me know when you think it's good to merge.

georgd commented 3 years ago

Thank you! I'm currently preparing a workshop and fixing some edge cases on the way. I'll be done tomorrow and will notify you then.

georgd commented 3 years ago

It’s ready to merge now.