Bugfix 20240905 - Githubissues

Just-Some-Bots / MusicBot

:musical_note: The original MusicBot for Discord (formerly SexualRhinoceros/MusicBot)

https://just-some-bots.github.io/MusicBot/

MIT License

3.14k stars 2.36k forks source link

Bugfix 20240905 #2423

Closed itsTheFae closed 2 months ago

itsTheFae commented 2 months ago

[x] I have tested my changes against the dev branch (the latest developmental version), and this pull request is targeting that branch as a base
[x] I have tested my changes on Python 3.8 or higher
[x] I have ensured my code is formatted using Black

Description

A few bug fixes for playnext & seek commands, as well as some tweaks to timers to prevent redundant messages.

BabyBoySnow commented 2 months ago

Did you do any testing on the playnow command to make sure it wasn't having the same behavior? I forgot to get around to it

itsTheFae commented 2 months ago

Did you do any testing on the playnow command to make sure it wasn't having the same behavior? I forgot to get around to it

Didn't run the playnow command, but the bug was down in _cmd_play by not passing head to the underlying entry logic in playlists. So it would have similarly not queued up correctly.

BabyBoySnow commented 2 months ago

Ah ok. Does this also fix play next only working with links?

itsTheFae commented 2 months ago

Ah ok. Does this also fix play next only working with links?

I haven't tested that. It should work the same as play for most things. The only thing that changed was passing the head parameter.

BabyBoySnow commented 2 months ago

Talk to you more on discord lol