Justineo / vue-awesome

Awesome SVG icon component for Vue.js, built-in with Font Awesome icons.
https://justineo.github.io/vue-awesome/demo/
MIT License
2.43k stars 206 forks source link

Update to vuejs v.3 + TypeScript #185

Open ayoubkhan558-zz opened 3 years ago

ayoubkhan558-zz commented 3 years ago

Update to vuejs v.3 + TypeScript

xFeXx commented 3 years ago

with 4.1.0 at least the vue-awesome/components/Icon.vue provided some typescript support. Since 4.2.0 with vue-awesome/components/Icon.js this is gone. @Justineo is there any plan to implement Typescript support? If not, is a PR for this allowed?

JakeAtTurner commented 3 years ago

Here is a fork with vue3.x support

https://github.com/JakeAtTurner/vue-awesome/tree/vue3.0-build

xFeXx commented 3 years ago

@JakeAtTurner thank you! @Justineo can we please use this?

reesericci commented 3 years ago

@JakeAtTurner can you deploy to github packages, and enable issues?

JakeAtTurner commented 3 years ago

@JakeAtTurner can you deploy to github packages, and enable issues?

use npm install --save JakeAtTurner/vue-awesome#vue3.0-build I have enabled the issues I might create a package later, but not entirely sure.

robbienohra commented 2 years ago

what's the main blocker here?

bbsimonbb commented 2 years ago

This is not working for me. I've installed @JakeAtTurner 's build. In my main.ts I have...

import { createApp } from 'vue'
import App from './App.vue'
import {createPinia} from 'pinia'
import Icon from 'vue-awesome/components/Icon'

createApp(App)
.use(createPinia())
.use(Icon)
.mount('#app')

no juice.