JvanKatwijk / dab-cmdline

DAB decoding library with example of its use
GNU General Public License v2.0
57 stars 29 forks source link

mp2processor class does not initialize ctx member variable #47

Closed borine closed 6 years ago

borine commented 6 years ago

When using the "UserData" field in callbacks, I get a segfault playing DAB audio. I found that this is because the userdata pointer i am given in the callback is null.

It turns out this is because the constructor in /library/src/backend/audio/mp2processor.cpp does not initialize the ctx member variable of the mp2processor object. By adding this->ctx = ctx; to the constructor body the segfault goes away and I get really faultless audio from the BBC national ensemble in the UK using an RPi 2B+ and a cheap RTL SDR USB device.

JvanKatwijk commented 6 years ago

Thankx corrected!

2018-08-06 13:08 GMT+02:00 borine notifications@github.com:

When using the "UserData" field in callbacks, I get a segfault playing DAB audio. I found that this is because the userdata pointer i am given in the callback is null.

It turns out this is because the constructor in /library/src/backend/audio/mp2processor.cpp does not initialize the ctx member variable of the mp2processor object. By adding this->ctx = ctx; to the constructor body the segfault goes away and I get really faultless audio from the BBC national ensemble in the UK using an RPi 2B+ and a cheap RTL SDR USB device.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/issues/47, or mute the thread https://github.com/notifications/unsubscribe-auth/AITzwEVXrEbNB2itl3KY7gVbj7JOqGyIks5uOCO6gaJpZM4VwMYs .

-- Jan van Katwijk

+31 (0)15 3698980 +31 (0) 628260355

borine commented 6 years ago

The fix for this has been lost in the recent changes for example 10. Could you possibly re-apply it? Thanks.

JvanKatwijk commented 6 years ago

done

2018-08-12 21:03 GMT+02:00 borine notifications@github.com:

The fix for this has been lost in the recent changes for example 10. Could you possibly re-apply it? Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/issues/47#issuecomment-412364579, or mute the thread https://github.com/notifications/unsubscribe-auth/AITzwHL4nOgGOV6lfZn0N33mvPjPStSfks5uQHwPgaJpZM4VwMYs .

-- Jan van Katwijk

+31 (0)15 3698980 +31 (0) 628260355

borine commented 6 years ago

Thanks - all working again now