JvanKatwijk / eti-stuff

experimental software for creating and interpreting eti frames
GNU General Public License v2.0
21 stars 12 forks source link

Update info of RTL-TCP input #27

Closed lars18th closed 6 years ago

lars18th commented 6 years ago

Hi,

In the Homepage (README.md) isn't indicated the parameter for configure&compile the RTL-TCP module:

where XXX refers to the input device being supported, one of (RTLSDR, SDRPLAY, AIRSPY, RAWFILES, WAVFILES)

You need to complete to the list: AIRSPY, SDRPLAY, RTLSDR, RAWFILES, WAVFILES, RTL_TCP. As indicated in the CMakeLists.txt file: https://github.com/JvanKatwijk/eti-stuff/blob/master/eti-cmdline/CMakeLists.txt#L60

Regards.

lars18th commented 6 years ago

Hi,

Futhermore, the eti-cmdline-* binary needs to print in the help the parameters of the module.

For example, for RTL_TCP these two parameters exists: ./eti-cmdline-rtl_tcp -H <ip> -I <port> But the program prints:

./eti-cmdline-rtl_tcp: invalid option -- '?'
 eti-cmdline-xxx options are

   -D number   time (in seconds) to look for a DAB ensemble
   -B Band     select DAB Band (default: BAND_III, or L_BAND)
   -P number   PPM correction
   -C channel  DAB channel to be used (5A ... 13F resp. LA ... LP)
   -G Gain     gain for device (range 1 .. 100)
   -Q          autogain for device (not all tuners support it!)
   -F filename load samples from file
   -E          only for files: continue after EOF (replay file)
   -O filename write output into a file (instead of stdout)
   -S          do not display quality messages while running
   -R filename (if configured) dump to an *.sdr file

   -h          show options and quit

I hope you can improve it! :smile:

andimik commented 6 years ago

You can contribute by changing the file and send a Pull request

JvanKatwijk commented 6 years ago

well, any implemented piece of software has "undocumented features", this happens to be one of them. I am not in favour of extending the READme and the help file to tell there features since usually the only reason they are there is that these were created to test something and their functionality might not be complete

2018-02-16 14:14 GMT+01:00 andimik notifications@github.com:

You can contribute by changing the file and send a Pull request

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/eti-stuff/issues/27#issuecomment-366231859, or mute the thread https://github.com/notifications/unsubscribe-auth/AITzwLi9fclGZ1ZPBi_eh3R5iiKbpOsRks5tVX80gaJpZM4SIPGe .

-- Jan van Katwijk

+31 (0)15 3698980 +31 (0) 628260355

lars18th commented 6 years ago

Hi @JvanKatwijk ,

is that these were created to test something and their functionality might not be complete

So, you don't have planed to full support RTL_TCP? Why not?

JvanKatwijk commented 6 years ago

why should I?

2018-02-16 15:52 GMT+01:00 lars18th notifications@github.com:

Hi @JvanKatwijk https://github.com/jvankatwijk ,

is that these were created to test something and their functionality might not be complete

So, you don't have planed to full support RTL_TCP? Why not?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/eti-stuff/issues/27#issuecomment-366256364, or mute the thread https://github.com/notifications/unsubscribe-auth/AITzwHshMXWopi2pJqeK3u23zeJDK0Doks5tVZYkgaJpZM4SIPGe .

-- Jan van Katwijk

+31 (0)15 3698980 +31 (0) 628260355

lars18th commented 6 years ago

why should I?

Because it just works and it's already implemented. No?

JvanKatwijk commented 6 years ago

No way, but if you feel it has to be changed, submit a pull request

2018-02-16 21:43 GMT+01:00 lars18th notifications@github.com:

why should I?

Because it just works and it's already implemented. No?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/eti-stuff/issues/27#issuecomment-366352830, or mute the thread https://github.com/notifications/unsubscribe-auth/AITzwD8gjc1Z22RMXam5ujCDWwm94cB1ks5tVehWgaJpZM4SIPGe .

-- Jan van Katwijk

+31 (0)15 3698980 +31 (0) 628260355

lars18th commented 6 years ago

Hi @JvanKatwijk ,

if you feel it has to be changed, submit a pull request

Following your suggestion I created a PR #35 for it.