K-S-V / Scripts

Collection of my scripts
GNU General Public License v3.0
635 stars 227 forks source link

PHP 7.2 count() warnings #99

Closed stefansundin closed 6 years ago

stefansundin commented 6 years ago

Due to: https://wiki.php.net/rfc/counting_non_countables

I get a ton of these warnings:

Fragments Total: 893, First: 1, Start: 1, Parallel: 8
PHP Warning:  count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1111

Warning: count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1111
PHP Warning:  count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1114

Warning: count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1114
PHP Warning:  count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1111

Warning: count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1111
PHP Warning:  count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1114

Warning: count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1114
PHP Warning:  count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1111

Warning: count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1111
PHP Warning:  count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1114

Warning: count(): Parameter must be an array or an object that implements Countable in AdobeHDS.php on line 1114
Downloading 3/893 fragments

It seems to still work, but my guess is that the compatibility will be removed in PHP 8.