search

K1rakishou / Kuroba-Experimental

Free and open source image board browser
GNU General Public License v3.0
690 stars 41 forks source link

Avoid thread watching #972

Closed ressidell closed 10 months ago

ressidell commented 11 months ago

Added feature to avoid tread watching when filter pattern is matched Respects filter order

Can be used instead of a convoluted regex pattern when multiple threads include the filter text you want to watch for, but you are only interested in one/some of them

K1rakishou commented 11 months ago

I don't fully understand what this flag is doing. When this flag is activated and there is a watch filter and they both have the same regex pattern then the watch filter won't bookmark the thread with the regex from avoid_watch filter?

ressidell commented 11 months ago

Yes it works like that, depending on the filter order, but It would be kinda meaningless to have the same pattern as both a watch and avoid_watch filter What I use it for: Let's say I have the watcher set up for thread /a/ but sometimes thread /b/ includes /a/ in their comment too In this case both /a/ and /b/ will be bookmarked With an avoid_watch /b/ filter placed before the watch /a/ ensures that /b/ is not bookmarked

K1rakishou commented 11 months ago

Oh so in this case avoid_filter for thread /b/ will have a pattern specific for /b/ so that it can find it and skip bookmarking it. I see.

Can you add an explanation to the filters help (question mark icon on filter creation popup screen) because this may not be very obvious for people.

K1rakishou commented 11 months ago

Can you also add an explanation to the filters help, please?

ressidell commented 10 months ago

Can you also add an explanation to the filters help, please?

Yeah, it's done too. Is the phrasing clear or should I write something more detailed?

K1rakishou commented 10 months ago

I think it's fine.