search

KDAB / Charm

The Cross-Platform Time Tracker
GNU General Public License v2.0
194 stars 70 forks source link

Replace task cannot be selected in Search/Replace dialog #281

Closed AndreSomers closed 8 years ago

AndreSomers commented 8 years ago

When trying to update a project code, I was attempting to use the search & replace option. Unfortunately, the button to open the task selector for the replace task does not work, thus rendering the dialog useless.

OS: Linux, version 1.11.1

frankosterfeld commented 8 years ago

What do you mean with "does not work"? It works for me here, one first needs to select the "Find" task, then the "Replace with" task (the order restriction seems unnecessary though). I.e. "Replace with" should be enabled once you selected something for "Find".

AndreSomers commented 8 years ago

I mean: does not work. No dialog opens for me when I click that button, while for the Find - Select Task button I do get the Select Task... dialog, nothing happens if I click the Replace With - Select Task button.

frankosterfeld commented 8 years ago

So the replace with button stays disabled even after you selected a task for "Find"?

AndreSomers commented 8 years ago

No, it is enabled. It just doesn't do anything.

TheOneRing commented 8 years ago

Could you provide a concrete example with all steps, as I fail to reproduce that behaviour.

AndreSomers commented 8 years ago

I cannot reproduce it anymore either. It may have been that I am confused by my widget style, which does not show the style to be disabled very clearly. I only see a difference in behavior when I hover over it, so earlier the button may have looked enabled to me but it really wasn't. So, I think that perhaps I did not have a find selected yet, but I am not sure any more.

What is the reason that the enabled status of the replace button depends on having a find task selected already? Why force the order?

frankosterfeld commented 8 years ago

I agree, enforcing the order seems unnecessary