KDAB / hotspot

The Linux perf GUI for performance analysis.
4.16k stars 257 forks source link

disassembly may be opened for "no binary" / "binary ??" with "address 0x0" #536

Closed GitMensch closed 1 year ago

GitMensch commented 1 year ago

Recognized when opening /tests/integrationtests/custom_cost_aggregation_testfiles/custom_cost_aggregation.perfparser from a fresh-built hotspot :

caller/callee disassembly

I suggest to early-error if there's a) no binary name or the name is ?? and b) stop-address is zero; additional possibly disable the Disassembly context menu for entries without a binary.

GitMensch commented 1 year ago

Also happens when using context-menu on a binary within Summary -> Top Hotspots per File, then Disassemble