fix source code search - Githubissues

KDAB / hotspot

The Linux perf GUI for performance analysis.

4.16k stars 257 forks source link

fix source code search #595

Closed lievenhey closed 7 months ago

lievenhey commented 10 months ago

The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: #577

GitMensch commented 10 months ago

Is there any option to adjust the search model test for that case?

lievenhey commented 10 months ago

I rewrote the search functions to use iterators instead + added some tests

GitMensch commented 8 months ago

Looking forward to get this merged.

GitMensch commented 7 months ago

I've pot some time into testing the appimage - the source handling in the Disassembly window now seems to work fine.

The only thing that feels strange is the go to function:

seems to be only usable with the context menu
CTRL+G is identical to ALT+G and selects/closes the Flame Graph; I guess that's the QT default we want to keep *but maybe CTRL+SHIFT+G can then open the go to dialogue as well

And of course #523 and #528 as well as #607 would be very helpful.