KDAB / hotspot

The Linux perf GUI for performance analysis.
4.16k stars 257 forks source link

add vscode applications to the predefined IDEs for "Open in Editor" #606

Closed GitMensch closed 8 months ago

GitMensch commented 8 months ago

@dfaure may want to have a look at this, too, as he added the call to the code binary

Question: Is it fine to push the suggested formatting change?

-    {"codium", "-g %f:%l:%c", QT_TRANSLATE_NOOP("MainWindow", "VSCodium"), "codium"}
-};
+    {"codium", "-g %f:%l:%c", QT_TRANSLATE_NOOP("MainWindow", "VSCodium"), "codium"}};
GitMensch commented 8 months ago

And just a note to people interested - this also works fine when running HotSpot on remote environments when started from vscode terminal (both on WSL and SSH remotes).

dfaure-kdab commented 8 months ago

Yes please apply the clang-format fix as well.

GitMensch commented 8 months ago

done