search

KGKf / kettle-cookbook

Automatically exported from code.google.com/p/kettle-cookbook
GNU Lesser General Public License v3.0
0 stars 0 forks source link

wz_jsgraphics does not properly detect ie #11

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In IE8, we get javascript runtime errors. In IE6, any kettle cookbook page 
(except the toc and the frontpage) look like the display of your computer just 
broke down. I'd like to report what it looks like in IE7, but that crashes 
before it can render. 

Although I think it'd be great to support all browsers, I really don't feel 
like spending time on fixing this for the moment. Reasoning is that just about 
any other browsers works fine, so users can still see docs (if this was a 
public internet site, I may judge differently). In addition, there are many 
bigger fish to fry. 

That said, anyone that wants fixes for IE should not feel restrained and are 
welcome to contribute.

Original issue reported on code.google.com by roland.bouman on 29 Sep 2010 at 9:30

GoogleCodeExporter commented 8 years ago

Original comment by roland.bouman on 15 Oct 2010 at 3:07

GoogleCodeExporter commented 8 years ago 
Hi roland,

it's samatar :-)
I use David google account to post fix for this issue.
Indeed David (one of our contractor) found the solution and applied fix for the 
following files:
-kettle.js
-wz_jsgraphics.js (of course)
-kettle-report.xslt

Please see attached files.

We have tested againts FireFox and IE 8 and 7 and it works.

Roland, please test and if you need more infos do not hesitate.

Thanks a lot and many thanks to David.

PS: we used the last changes in trunk.

Samatar

Original comment by david.bo...@gmail.com on 25 Oct 2010 at 2:26

Attachments:

GoogleCodeExporter commented 8 years ago 
Hi Samatar, David!

thanks guys! I'll take a look this evening. It would be *awesome* to get this 
to work for IE too :)

Original comment by roland.bouman on 25 Oct 2010 at 3:16

GoogleCodeExporter commented 8 years ago 
For now, I am marking this as fixed. Issues for IE6 have not been fixed, but 
really, I'm in serious doubt whether that can be called a bug at all.

Original comment by roland.bouman on 25 Oct 2010 at 10:41