linuxgurugamer
commented
1 year ago Might be useful to see the size of ALL the filesystems on the computer, you only showed one
Closed VulcanRidr closed 1 year ago
linuxgurugamer
commented
1 year ago Might be useful to see the size of ALL the filesystems on the computer, you only showed one
VulcanRidr
commented
1 year ago Thanks @linuxgurugamer. I only included the one that ckan seemed to be complaining about. Here is my list, excluding udev and tmpfs partitions:
Filesystem Size Used Avail Use% Mounted on
/dev/mapper/vg00-root 2.0G 1.3G 630M 67% /
/dev/mapper/vg00-usr 15G 7.7G 6.2G 56% /usr
/dev/sda3 474M 135M 311M 31% /boot
/dev/sdc1 197M 6.6M 191M 4% /boot/efi
/dev/mapper/vg00-var 15G 2.8G 12G 21% /var
home 56G 25G 31G 45% /home
shuttlepod/GOG Games 3.5T 5.7G 3.5T 1% /home/storm/GOG Games
shuttlepod 3.5T 31G 3.5T 1% /home/storm/shuttlepod
shuttlepod/Kerbal 3.5T 1.0M 3.5T 1% /home/storm/shuttlepod/KerbalIt appears that the problem is not with the game install directory, but rather in /tmp. My /tmp is on /, and I tend to run a skinny /tmp...So I have a question, is it possible to change ckan's temp directory? I have 12GB free on /var/tmp, so that would be a better place for me to point ckan's temp directory...
And, btw, this bug can be closed out.
HebaruSan
commented
1 year ago Comparing two DirectoryInfo objects with == may not work as expected, or maybe Mono implemented it wrong:
The documentation uses a far more awkward (Windows-only) construction:
https://learn.microsoft.com/en-us/dotnet/api/system.io.directoryinfo?view=netframework-4.7.2
if (source.FullName.ToLower() == target.FullName.ToLower())StackExchange consensus agrees:
... though on second thought, that would not explain this issue. The partition is mounted at /home/storm/GOG Games and we're checking /home/storm/GOG Games/1.12.4-oldmods, which would not need the == to work since it would be caught by IsAncestorOf.
VulcanRidr
commented
1 year ago So I don't think it is the GOG Games directory at all. I think that (and this is on linux) ckan is trying to use a temporary directory for the download of mods...By default, it is using /tmp. I freed up space on / (where /tmp is located), and have 1GB free. When I tried to install from a .ckan this time it told me it needed to get
Need to store 5.6 GiB to /home/storm/Kerbal/1.12.4-oldmods/game, but only 1,000.5 MiB is available!
$ df /tmp
Filesystem 1K-blocks Used Available Use% Mounted on
/dev/mapper/vg00-root 2026008 891776 1024544 47% /Is there a way to change the temp directory for ckan?
HebaruSan
commented
1 year ago Here are the three places where CKAN checks for free space:
It doesn't check the temp folder, because as of #3666, we don't download to a temp folder anymore.
VulcanRidr
commented
1 year ago Interesting, because on linux, it seems to be looking at something on the root filesystem, because once I expanded my root filesystem, it stopped complaining. In either case, we can close this bug report...
HebaruSan
commented
1 year ago Right, I suspect there's a bug in how the folder path is translated to a partition. .NET/Mono doesn't provide this natively (presumably because it's non-trivial), so we have had to hack it in, and if we can identify what's going wrong in this instance, we can improve it for future versions.
HebaruSan
commented
1 year ago ... well, that's just great. I added some debug code to probe this in an Ubuntu VM, and DriveInfo.GetDrives() returns a bunch of junk devices from snapd, but no actual mounted filesystems other than the root!ââ
45568438272 / / /
0 /snap/bare/5 /snap/bare/5 /snap/bare/5
0 /snap/core20/1852 /snap/core20/1852 /snap/core20/1852
0 /snap/core18/2745 /snap/core18/2745 /snap/core18/2745
0 /snap/core22/634 /snap/core22/634 /snap/core22/634
0 /snap/core18/2751 /snap/core18/2751 /snap/core18/2751
0 /snap/core20/1891 /snap/core20/1891 /snap/core20/1891
0 /snap/core22/750 /snap/core22/750 /snap/core22/750
0 /snap/firefox/2710 /snap/firefox/2710 /snap/firefox/2710
0 /snap/firefox/2559 /snap/firefox/2559 /snap/firefox/2559
0 /snap/gnome-3-38-2004/137 /snap/gnome-3-38-2004/137 /snap/gnome-3-38-2004/137
0 /snap/gnome-3-38-2004/140 /snap/gnome-3-38-2004/140 /snap/gnome-3-38-2004/140
0 /snap/gnome-42-2204/105 /snap/gnome-42-2204/105 /snap/gnome-42-2204/105
0 /snap/gnome-42-2204/102 /snap/gnome-42-2204/102 /snap/gnome-42-2204/102
0 /snap/gtk-common-themes/1535 /snap/gtk-common-themes/1535 /snap/gtk-common-themes/1535
0 /snap/gtk-common-themes/1514 /snap/gtk-common-themes/1514 /snap/gtk-common-themes/1514
0 /snap/hunspell-dictionaries-1-7-2004/2 /snap/hunspell-dictionaries-1-7-2004/2 /snap/hunspell-dictionaries-1-7-2004/2
0 /snap/snap-store/959 /snap/snap-store/959 /snap/snap-store/959
0 /snap/snapd/19122 /snap/snapd/19122 /snap/snapd/19122
0 /snap/snap-store/638 /snap/snap-store/638 /snap/snap-store/638
0 /snap/snapd-desktop-integration/57 /snap/snapd-desktop-integration/57 /snap/snapd-desktop-integration/57
0 /snap/snapd/19361 /snap/snapd/19361 /snap/snapd/19361
0 /snap/snapd-desktop-integration/83 /snap/snapd-desktop-integration/83 /snap/snapd-desktop-integration/83
45568438272 /var/snap/firefox/common/host-hunspell /var/snap/firefox/common/host-hunspell /var/snap/firefox/common/host-hunspell
535801856 /boot/efi /boot/efi /boot/efi
/run/user/1000/doc
0 /run/user/1000/gvfs /run/user/1000/gvfs /run/user/1000/gvfs
DEBUG CKAN.CKANPathUtils - Dir /media/sf_Kerbal_Space_Program is on drive /$ df -h
Filesystem Size Used Avail Use% Mounted on
tmpfs 795M 1.6M 794M 1% /run
/dev/sda5 63G 17G 43G 29% /
tmpfs 3.9G 8.0K 3.9G 1% /dev/shm
tmpfs 5.0M 4.0K 5.0M 1% /run/lock
/dev/sda1 511M 4.0K 511M 1% /boot/efi
Kerbal_Space_Program 5.5T 2.8T 2.8T 50% /media/sf_Kerbal_Space_Program
CKAN 5.5T 2.8T 2.8T 50% /media/sf_CKAN
tmpfs 795M 128K 795M 1% /run/user/1000It never crossed my mind that Mono's implementation of this could be that completely and totally and shockingly broken and unusable and useless. I originally tested this on my single filesystem dual boot setup on Linux and just assumed that GetDrives would, you know, get the drives.
I guess we have to turn the disk space check off completely for non-Windows platforms, since it can't actually be done. đ
(... and in case anyone else goes hunting through the API, Directory.GetLogicalDrives() returns the same list of garbage.)
HebaruSan
commented
1 year ago GetDrives calls GetLogicalDrives:
GetLogicalDrives is implemented in C, with goto and lots of magic numbers and pointer manipulations (no wonder it doesn't work đđ¤ˇ):
https://github.com/mono/mono/blob/771947925a512a91e1ac88eb463ec845cafc2807/mono/metadata/icall.c#L7342-L7404 https://github.com/mono/mono/blob/771947925a512a91e1ac88eb463ec845cafc2807/mono/metadata/w32file-unix.c#L3986-L4256
It attempts to parse /proc/self/mountinfo, which contains the desired entry in this format:
1210 28 0:49 / /media/sf_Kerbal_Space_Program rw,nodev,relatime shared:610 - vboxsf Kerbal_Space_Program rw,iocharset=utf8,uid=0,gid=998,dmode=0770,fmode=0770,tag=VBoxAutomounterSo somewhere in that C code, that entry gets filtered out. Presumably on one of the ignore_entry = TRUE lines.
... I think it's the final one; the if/else if/... checks are hard-coded to include /, then they allow entries of type overlay or aufs or fuse or nfs, and then they just discard everything else! Astoundingly brain-dead.
VulcanRidr
commented
1 year ago Right, that is ubuntu...One reason I don't run Ubuntu. I hate snaps. You also, I see, have everything except /boot/efi in a single filesystem. That may be a better way to go for something like this, but I segregate my filesystems out of habit. Now, having said that, I think that either mono or ckan uses /tmp as a quick place to stash during downloads, then it actually caches the mods in the .local/share/CKAN/downloads directory.
HebaruSan
commented
1 year ago You also, I see, have everything except /boot/efi in a single filesystem
No, that VM has more mounted filesystems than that, courtesy of VirtualBox shared folders:
Kerbal_Space_Program 5.5T 2.8T 2.8T 50% /media/sf_Kerbal_Space_Program
CKAN 5.5T 2.8T 2.8T 50% /media/sf_CKANThat's what I was testing. /media/sf_Kerbal_Space_Program should have been included in the list returned by GetDrives but was not.
HebaruSan
commented
1 year ago As far as I know, /tmp plays no role in this whatsoever. If you have a reason for thinking that, please share it.
Is there an existing issue for this?
Operating System
Devuan Linux
CKAN Version
1.32.0.23098
Game Version
1.12.4 or 1.12.5 (happened on both)
Did you make any manual changes to your game folder (i.e., not via CKAN)?
No
Describe the bug
This looks similar to #3768, except ckan does not generate exceptions for me, to my knowledge. I started with a clean copy of the GOG version of KSP 1.12.4 and 1.12.5. I tried to install from a .ckan file, and when I did, it told me that I only had 537.8MB of space free, and it needed to download or store 5.6GB of data. Having said that, I have 3.5TB free on this dataset:
Steps to reproduce
Relevant log output