`KSPe.InstallChecker` is not being able to show its Modals

KSP-ModularManagement / KSPe

Extensions and utilities for Kerbal Space Program

http://ksp.lisias.net/add-ons/KSPAPIExtensions

Other

11 stars 5 forks source link

`KSPe.InstallChecker` is not being able to show its Modals #54

Closed Lisias closed 1 year ago

Lisias commented 1 year ago

The KSPe.InstallChecker is not being able to communicate to the user the need to restart the system because 000_KSPe is freaking out when it can't handle the new auxiliary DLLs in the PluginData.

The solution is to instrument KSPe to do not emit Modal Windows when:

KSPe.InstallChecker is present
There're more than one copy of KSPe Assembly on memory.

As this is a situation where InstallChecker will need the Modal to talk to the user.

Lisias commented 1 year ago

This fix is mandatory for CurseForge users, otherwise future KSPe updates will be troublesome for them.

Everybody else should not be affected.

Lisias commented 1 year ago

Fixed on commit https://github.com/net-lisias-ksp/KSPe/commit/991e2e4d73a9d376708dc9d594d2bbd376679793 .

Lisias commented 1 year ago

The code for this issue was rolled back, this code will not reach the mainstream.

Issue #50 solves the problem in a better way.