TS upgrades do not apply if completed in flight scene - Githubissues

KSP-RO / RealAntennas

KSP Mod to add better antenna / link calculations to CommNet.

2 stars 5 forks source link

TS upgrades do not apply if completed in flight scene #6

Closed Capkirk123 closed 5 months ago

Capkirk123 commented 6 months ago

The use case is RP-1 simulations that happen in far future where a facility upgrade will get completed.

RP-1 will call UpgradeableFacility.SetLevel() which in turn will fire the following events:

GameEvents.OnKSCFacilityUpgrading
GameEvents.OnUpgradeableObjLevelChange
In a coroutine GameEvents.OnKSCFacilityUpgraded

Ref: https://discord.com/channels/319857228905447436/512556346869284864/1144421956649758872

Actually it looks like they do not apply in space center scene either. At least Kerbalism will report wrong data rates until a scene change is done.

Migrated from https://github.com/DRVeyl/RealAntennas/issues/94

DRVeyl commented 6 months ago

Add listeners to one of those events and ask the network to reset. Might be as easy as calling https://github.com/DRVeyl/RealAntennas/blob/master/src/RealAntennasProject/RACommNetScenario.cs#L99 ?