KSP-RO / RealismOverhaul

Multipatch to KSP to give things realistic stats and sizes
369 stars 280 forks source link

Add dependency on tweakscalerescaled-redist #2996

Closed JonnyOThan closed 1 month ago

JonnyOThan commented 1 month ago

Since FAR depends on tweakscale-redist, users are prompted to choose between tweakscale-redist and tweakscaleRescaled-redist when installing. Adding an explicit dependency here should remove that choice (which doesn't really matter) and prevent future problematic conflicts.

siimav commented 1 month ago

Now the question is how does CKAN behave when someone tries to update their existing install?

JonnyOThan commented 1 month ago

Yeah never mind, this doesn't work too well on the current version of CKAN. It still forces you to choose when installing, and if you picked the wrong one it doesn't report the conflict until later

siimav commented 1 month ago

To be clear - did you try with RO-only or with RO/RP-1 Express Install?

JonnyOThan commented 1 month ago

RO only, but I don't think it would be any different.

JonnyOThan commented 1 month ago

in ckan 1.34.5 (unreleased dev build), this change prompts an "update" action, and if you select it then you get: image

So you'd still need to manually unselect tweakscale-redist and select tweakscalerescaled-redist (which does work).

Fresh installs still have the above problem:

image

JonnyOThan commented 1 month ago

FYI, HebaruSan pointed out that since AJE depends on FAR, the dependency declaration needs to be before AJE for this to work properly. I haven't yet re-tested CKAN's behavior with that change though.