Closed camiloramirezgo closed 2 years ago
Hi @camiloramirezgo - thanks so much for this clear review. Can you make a pull request with your branch so I can respond there? In short, I think also everything you suggest can be accepted as is, but I'd like to make a few tweaks. We can do that on your branch and discuss in the PR. Ace!
Closed by #3
I will provide feedback and some ideas I have for the lab to make it more challenging for the students (which I think can be encouraging for them). If we agree on some of these changes then I can create a PR to include them.
In the import statements
plotly express
is imported asex
, the standard alias ispx
.I think we can ask the students to create some of the formulas we are giving to them as the
crf
and thelcoe
. That way, they will be able to interact a bit with Python. Thus, I think a stage 0 would be useful for them, where we provide some of the basic operators in python so they can get familiarized with them and be able to use them in stages 1 and 2. The idea of this section would be to work as a reference (not to spend much time on it) so they can check what they could use when implementing the formulas. I could write such section and include it in the PR.Then the part where we calculate the
crf
could be like this:The same for the
lcoe
formula:Additionally, we can have a couple of checker functions to check if the values are correct. We can store such functions in a Python module outside the notebook and import them. Something like the following for the
crf
formula:An for the
lcoe
calculation we can have the following, which will also give feedback in the case the result is correct:This will work for both if the result is
False
or if it raises an error. This checker would replace the assert test currently in place.In stage 2, the input for
capacity
is currently in MW and should be in kW to be consistent with the units of theextended_lcoe
function:I am also a bit confused about the variable name
overnight_cost
. I understand this refers to the CAPEX right?In the
extended_lcoe
function, we make thelcoe
calculation again but in a slightly different way. Wouldn't it be better to reuse thelcoe
function that we have already coded, so we avoid confusion? like:When we use the
extended_lcoe
function for the first time, the value passed asload_factor
is incorrect:capacity * 8760 * 0.75
, this should be 0.75 only.We should change the input value of
technical_lifetime
to something like(10, 1, 50)
to prevent the slider raising a division by zero error and select negative values:About how to extend stages 2 and 3, I could only think on maybe showing a plot per technology disaggregating the
lcoe
value per cost type (capital, fixed and variable) and make them reflect on the importance of each cost for thelcoe
and the technology.For this, some changes would need to be done to the
extended_lcoe
function and some additional code.I will push my branch so you can check all the changes I discussed here. Please feel free to comment/reject anything, I am completely open to ideas.