KVSlab / turtleFSI

Monolithic Fluid-Structure Interaction (FSI) solver
https://turtlefsi2.readthedocs.io/en/latest/
GNU General Public License v3.0
63 stars 23 forks source link

pytest missing laplace as mesh moving #72

Closed keiyamamo closed 1 year ago

keiyamamo commented 1 year ago

I found out that the pytest actually does not test laplace.py because the parameter is not passed inside test_laplace function. The default parameter for extrapolation is set to biharmonic and I’m pretty sure that is the one used for test_laplace. https://github.com/KVSlab/turtleFSI/blob/29e8724fa726e699f7d0b1c57d80a5d19f5a8a8c/tests/test_turtleFSI.py#L67-L86

Here is coverage report that shows we are not hitting laplace.py

--------- coverage: platform darwin, python 3.10.10-final-0 ----------
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
turtleFSI/__init__.py                       1      0   100%
turtleFSI/modules/__init__.py               1      0   100%
turtleFSI/modules/biharmonic.py            14      0   100%
turtleFSI/modules/common.py               111     69    38%
turtleFSI/modules/domain.py                43     22    49%
turtleFSI/modules/elastic.py               12      0   100%
turtleFSI/modules/fluid.py                 20      0   100%
turtleFSI/modules/laplace.py               16     16     0%
turtleFSI/modules/newtonsolver.py          52      2    96%
turtleFSI/modules/no_extrapolation.py       2      0   100%
turtleFSI/modules/no_fluid.py               8      0   100%
turtleFSI/modules/no_solid.py               8      0   100%
turtleFSI/modules/solid.py                 36     13    64%
turtleFSI/monolithic.py                   128     19    85%
turtleFSI/run_turtle.py                     8      1    88%
turtleFSI/utils/Probe.py                   70     49    30%
turtleFSI/utils/Womersley.py              138    119    14%
turtleFSI/utils/__init__.py                16     12    25%
turtleFSI/utils/argpar.py                 142     58    59%
-----------------------------------------------------------
TOTAL                                     826    380    54%

I will fix it and will create a PR.