search

KVSlab / turtleFSI

Monolithic Fluid-Structure Interaction (FSI) solver
https://turtlefsi2.readthedocs.io/en/latest/
GNU General Public License v3.0
63 stars 23 forks source link

Revert config #77

Closed keiyamamo closed 1 year ago

keiyamamo commented 1 year ago

Ref #75

johannesring commented 1 year ago

@keiyamamo - Is pyaml no longer needed now? Can it be removed?

keiyamamo commented 1 year ago

@johannesring I tested deleting pyaml and it is still necessary.

keiyamamo commented 1 year ago

@johannesring
I tried to remove pyaml but then I got the following error from domain.py.

 File "/Users/keiyamamoto/Documents/turtleFSI/turtleFSI/modules/domain.py", line 103, in assign_domain_properties
    assert isinstance(solid_properties, list), "solid_properties must be a list of dictionaries"
AssertionError: solid_properties must be a list of dictionaries

Even though solid_properties was passed correctly as parameter, it is str and not list or dictionary. I would say keeping pyaml is the easiest for now. If this seems fine, I will merge the PR.