search

KVSlab / turtleFSI

Monolithic Fluid-Structure Interaction (FSI) solver
https://turtlefsi2.readthedocs.io/en/latest/
GNU General Public License v3.0
63 stars 23 forks source link

Issue new release of TurtleFSI to generate DOI for Nature Comms Paper #92

Closed dbruneau-mie closed 1 year ago

dbruneau-mie commented 1 year ago

Hi @keiyamamo @jorgensd @johannesring @KristianValen-Sendstad, I would like to issue a new release (v2.2.1) of TurtleFSI to generate a DOI in Zenodo, so I can reference it in my Nature Comms paper. Do you have any concerns about doing this?

keiyamamo commented 1 year ago

There is no concerns from my side.

jorgensd commented 1 year ago

No objections. Frequent releases are good for users anyhow

johannesring commented 1 year ago

No problem, but it would be good to bump the version number when making a release. There have been a few releases lately, but setup.py is still at version 1.5.

KristianValen-Sendstad commented 1 year ago

No objection from me, DAB.

KVS

On Thu, 12 Oct 2023 at 10:15, Johannes Ring @.***> wrote:

No problem, but it would be good to bump the version number when making a release. There have been a few releases lately, but setup.py is still at version 1.5.

— Reply to this email directly, view it on GitHub https://github.com/KVSlab/turtleFSI/issues/92#issuecomment-1760034909, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4X54JOPSSWRYEAVGRYVN3X7AQU5ANCNFSM6AAAAAA55Z237Q . You are receiving this because you were mentioned.Message ID: @.***>

dbruneau-mie commented 1 year ago

Ok, I will increment the version number in setup.py. Have the recent versions code been passing the built-in pytest?

DAB

On Thu, Oct 12, 2023, 5:10 p.m. KristianValen-Sendstad < @.***> wrote:

No objection from me, DAB.

KVS

On Thu, 12 Oct 2023 at 10:15, Johannes Ring @.***> wrote:

No problem, but it would be good to bump the version number when making a release. There have been a few releases lately, but setup.py is still at version 1.5.

— Reply to this email directly, view it on GitHub https://github.com/KVSlab/turtleFSI/issues/92#issuecomment-1760034909,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA4X54JOPSSWRYEAVGRYVN3X7AQU5ANCNFSM6AAAAAA55Z237Q>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/KVSlab/turtleFSI/issues/92#issuecomment-1760370990, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANWLGEMDGBFQL22K3N7WF53X7BMF5ANCNFSM6AAAAAA55Z237Q . You are receiving this because you authored the thread.Message ID: @.***>

johannesring commented 1 year ago

Yes, the tests are passing (see here), but the badge at the top of README.md is pointing to a Travis test that does not seem to be running.

keiyamamo commented 1 year ago

@dbruneau-mie test is automatically run with github everyday. @johannesring We should probably remove travis from readme as well as .travis.yml

johannesring commented 1 year ago

@keiyamamo - yes, I will do that.

keiyamamo commented 1 year ago

@johannesring Thanks! For some reason, documentation badge says “failing” even though the documentation looks fine. It would be nice to fix it but I’m not sure when the documentation is built in the current setting.

johannesring commented 1 year ago

I guess the documentation on readthedocs is autobuilt on commits. It is probably configured on readthedocs.

dbruneau-mie commented 1 year ago

I created a new release, but could not get zenodo to automatically create a DOI. I ended up archiving an older version of the repo manually at:

https://zenodo.org/doi/10.5281/zenodo.10001935