KabanFriends / CraftGR

Touhou Project music player for Minecraft
https://modrinth.com/mod/craftgr
GNU Lesser General Public License v3.0
20 stars 2 forks source link

With mod Ad Astra! Conflict and collapse #19

Open DX12xyz opened 2 months ago

DX12xyz commented 2 months ago

Minecraft version : 1.20.1 Forge version : 47.3.10 Mod and its version : ad_astra-forge-1.20.1-1.15.18 botarium-forge-1.20.1-2.3.4 cloth-config-11.1.136-forge craftgr-1.5.1-mc1.20.1 resourcefulconfig-forge-1.20.1-2.1.2 resourcefullib-forge-1.20.1-2.1.29 Log : minecraft-exported-logs-2024-09-22T00-17-22.log

PwRhGaStPY commented 3 weeks ago

The issue can be replicated, as I am having the same problem. ad_astra-forge-1.20.1-1.15.18 botarium-forge-1.20.1-2.3.4 cloth-config-11.1.136-forge craftgr-1.5.1-mc1.20.1 resourcefulconfig-forge-1.20.1-2.1.2 resourcefullib-forge-1.20.1-2.1.29 YetAnotherConfigLib-3.6.1+1.20.1-forge Log: https://mclo.gs/qvnRDes I hope it'll be noticed and fixed soon.

PwRhGaStPY commented 21 hours ago

A participant in the issue I created on Ad Astra's side has proposed a possible fix to this problem:

This is CraftGR's fault, they shadow without relocating jlayer. Instead they should jar-in-jar it as Ad Astra does, or if they must shadow (there are very few reasons for this) relocate it to a different package using shadow's relocate feature. - ChiefArug

I hope this or something similar gets implemented in the future.