KageJittai / lets-trade-5e

A Foundry VTT module which allows you to send and receive items from other players.
MIT License
11 stars 14 forks source link

[Incompatibility] Issues with DAE active effects on traded items DND5e #31

Open Highlander345 opened 2 years ago

Highlander345 commented 2 years ago

Issue: Bonus damage modifier pulled onto trade recipients character in the dice rolls but not as an effect.

Steps to reproduce:

  1. Create a weapon on character 1 (I created a scimitar that does 1d6 + @mod damager)
  2. Create a second item on character 1 that provides the active effect of bonus damage on equip (In this case I created a weapon that can be equipped or unequipped to give all melee weapons an additional +d4 damage, this means on character 1 the damage roll is 1d6 +@mod +1d4)
  3. With the damage modifier equipped, trade the weapon to character 2 (Character 2 now holds a scimitar that shows it does 1d6 + @mod damage, no active effects copied over)
  4. Rolling an attack on character two shows the damage roll as 1d6 + @mod + 1d4 - 1d4, the d4's are rolled seperately meaning negative damage is possible or breaking the weapons damage limits. Because the active effect pulled across is a melee damage bonus effect, this applies to all melee weapons and does not go even if the scimitar is deleted.

Its such a niche case that I think its probably not fixable, but just want to make you aware.