KaiHabermann / decayangle

https://kaihabermann.github.io/decayangle/
MIT License
1 stars 1 forks source link

Four body example #41

Closed KaiHabermann closed 5 months ago

KaiHabermann commented 5 months ago

Closes #37

Branch with notebooks, including:

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.63%. Comparing base (5f80f34) to head (300df29).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #41 +/- ## ======================================= Coverage 87.63% 87.63% ======================================= Files 6 6 Lines 631 631 Branches 107 107 ======================================= Hits 553 553 Misses 41 41 Partials 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mmikhasenko commented 5 months ago

Nice! How long does it take to run? Would the notebooks be useful as a part of documentation.

If the running time is short, I'd be nice to run them in CI and reference HTML in the GitHub pages for the ## Examples section.

Meanwhile, I suggest removing cell output from this PR.

mmikhasenko commented 5 months ago

An example of extended conf.py that renders notebooks (feel like should be a separate PR since requires more work)

KaiHabermann commented 5 months ago

The notebooks take about a minute with the 1000x1000 grid. Going 500x500 should reduce this to 15 seconds, which may be fine. We could set the trigger for the render on manual or on release.