search

Kakadu / lablqml

Interfacing Qt/QML with OCaml. Formely known as lablqt
http://kakadu.github.io/lablqml
GNU Lesser General Public License v2.1
159 stars 17 forks source link

Use ocaml-migrate-parsetree #55

Closed bluddy closed 7 years ago

bluddy commented 7 years ago

This allows us to not worry about keeping the ppx code up to date. For example, the ppx as of now supports only 4.03.

Kakadu commented 7 years ago

@bluddy we also need to specify --as-ppx option to compile demos. Can you Fix the PR ?

bluddy commented 7 years ago

Done. I also found that the ppx driver wasn't running. You're supposed to invoke it by just linking Driver_main whose sole job is to call the driver function, but there's an ordering issue there with ocamlbuild -- call it too soon and the registration doesn't happen. So I just called it manually.

I'm getting a missing symbol for caml_c_thread_register and caml_c_thread_unregister on the demos. This means everything up to linkage works, but what am I not linking against?

Kakadu commented 7 years ago

I see these issues too but they are probably are not related to your changes. I think that I have seen these kind of issues somewhere in the internet. Going to investigate it tomorrow

bluddy commented 7 years ago

Adding -thread after $(OCAMLOPT) in the $(OUT) rule of the helloworld makefile solves this issue. This obviously doesn't work when the linker is g++.

Kakadu commented 7 years ago

I fixed compilations issues related to the demos in commit https://github.com/Kakadu/lablqml/commit/fe5e42bc0507cee74d938834ad8efbf1d203d1c4

I needed to manually fix call to the syntax extension here. @bluddy , do you know can we somehow improve this by using some OMP-specific build rule or putting something top the _tags file? Should this be improved at all?

bluddy commented 7 years ago

There's some stuff here but I don't know if it's worth the effort.