search

KalobTaulien / wagtail-livepreview

Wagtail Live Preview lets you view your page changes as you make them in the Wagtail Admin.
Other
29 stars 6 forks source link

Not compatible to Django 3 #13

Open kakulukia opened 4 years ago

kakulukia commented 4 years ago

File "/Users/andy/projects/po-website/.venv/lib/python3.8/site-packages/livepreview/wagtail_hooks.py", line 9, in

from django.contrib.staticfiles.templatetags.staticfiles import static

ModuleNotFoundError: No module named 'django.contrib.staticfiles.templatetags'

kakulukia commented 4 years ago

So sad .. just found it and wanted to try it out right away, but :(

KalobTaulien commented 4 years ago

@kakulukia this would be a really easy PR, and I'd welcome it!

The solution here to swap out the import as outlined in this Stack Overflow answer: https://stackoverflow.com/a/62266193/2074077

jkevingutierrez commented 4 years ago

I can see that this was already fixed:

https://github.com/KalobTaulien/wagtail-livepreview/commit/dfd2e0ea1dc857c8115e29e81c43f9c8ad2d5a10#diff-c362f83e8ab2a82177126485b9e8e7c2R9

But trying to install wagtail-livepreview using pip, installs an old version without those changes.

It would be good to have the latest version published