search

KangoExtensions / kango

Kango framework issue tracker
74 stars 7 forks source link

Kango 1.8.0 breaks @all-frames header directive in Firefox #153

Open prestonwho opened 8 years ago

prestonwho commented 8 years ago

Hey -

I have written an extension that relies on the all-frames directive. Under Kango 1.7.9 my script works fine using the following:

// ==UserScript==
// @name NAME
// @namespace com.example.NAME
// @include https://*.example.com/*
// @require lib/jquery.js
// @require lib/utility.js
// @all-frames true
// ==/UserScript==

Under Kango 1.8.0, my script continues to work for iframes under Chrome, but under Firefox (Developer Edition 46.0a2, tested both with and without e10s) the userscript appears to be included only on the main page (not in iframes). If I right-click, select "This Frame | Show Only This Frame", my userscript runs on the page as expected, when it's no longer inside an iframe.

I've started poking around in Kango's code to see if I can pinpoint what changed between 1.7.9 and 1.8.0, but haven't found it yet... and I don't have a lot of time to devote to it when I can just revert to 1.7.9 and wait for an official fix. :-)

Thanks

OlivierBonjour commented 7 years ago

Hi, I'm having the same problem, are you still on 1.7.9 or you found a way to fix this on 1.8.0 ?

prestonwho commented 7 years ago

I haven't tried again with 1.8.0 since shortly after opening this thread. With no update and no response, I've been content to stick with 1.7.9.