KanoComputing / kano-code

πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»Kano Code
https://world.kano.me
GNU General Public License v2.0
16 stars 5 forks source link

creator: Change file type of export to json #1856

Closed onishiweb closed 4 years ago

onishiweb commented 4 years ago

Just a thought on this, if we want our users to be able to double click on a Kano share (KC, MA, anything else) and for it to be able to auto-launch the associated app then we basically have to have a designated extension for each app (even if the format underpinning them is actually JSON). If this is something that we don't care about doing then this is absolutely fine but just wanted to throw it out there.

@tombettany This change is just for the challenge creator that uses json, it won't effect regular user exports of their own creations.

tombettany commented 4 years ago

Ah! Then ignore me.

TeamKano commented 4 years ago
Coverage summary
Statements 29.36% 2003/6823
Branches 20.23% 212/1048
Functions 29.39% 650/2212
Lines 29.23% 1935/6620

From Jenkins: kano-code/PR-1856