Closed lordrip closed 1 month ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Attention: Patch coverage is 92.15686%
with 4 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
main@f95f50e
). Learn more about missing BASE report.
Files with missing lines | Patch % | Lines |
---|---|---|
...catalog/generator/CamelYamlDslSchemaProcessor.java | 88.57% | 3 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I do not understand what to look at and verify exactly. What is modified functionally?
Adding support for
oneOf
elements in the JSON Schema, used byerrorHandler
, the new tokenizer EIP, among others. If you check Camel 4.9.0-SNAPSHOT, you'll notice that the tokenizer doesn't show any tokenizer option, just the defaultid
anddescrption
.
In the past, oneOf
was supported at the root level, in a separate code branch, now that code branch was consolidated for all oneOf
fields.
I tried in VS Code and I can still create routes.
I wouldn't expect less 😅
Context
Currently, we have partial support for the
oneOf
schemas.This commit cleans up the generated schemas, by removing the
not
definition fromoneOf
and also removing the empty properties like:Test the changes live: https://lordrip.github.io/kaoto/
fix: https://github.com/KaotoIO/kaoto/issues/1550 fix: https://github.com/KaotoIO/kaoto/issues/948