search

KaotoIO / kaoto

The UI of the Kaoto project
https://kaoto.io
Apache License 2.0
38 stars 29 forks source link

feat #734: Delete a node using the delete key #1566

Closed ibek closed 2 weeks ago

ibek commented 1 month ago

also for #1477

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 67.50000% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d985f82). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../ui/src/components/Visualization/Canvas/Canvas.tsx 45.83% 11 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1566 +/- ## ======================================= Coverage ? 79.87% Complexity ? 272 ======================================= Files ? 277 Lines ? 7910 Branches ? 1553 ======================================= Hits ? 6318 Misses ? 1481 Partials ? 111 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lordrip commented 2 weeks ago

Hi @ibek, thanks for the contribution, I'll close this PR since we're preparing for the next release, nevertheless, we're gonna use it as a base for the implementation :pray: