KaotoIO / kaoto

The UI of the Kaoto project
https://kaoto.io
Apache License 2.0
38 stars 29 forks source link

fix(Canvas): Fix Edge source misplaced for containers #1584

Closed lordrip closed 1 month ago

lordrip commented 1 month ago

Context

In order to make room for the node's secondary label, the containers were expanded by 10px.

The problem comes when in vertical layout, that additional size is not taken into account when calculating the edges since the size is only reflected in the visualization part and not during the layout calculation.

The solution for now is to increase the group padding just a bit to make the secondary label to fit.

Before After
image image

fix: https://github.com/KaotoIO/kaoto/issues/1575

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@da73c38). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1584 +/- ## ======================================= Coverage ? 79.91% Complexity ? 272 ======================================= Files ? 280 Lines ? 7998 Branches ? 1527 ======================================= Hits ? 6392 Misses ? 1545 Partials ? 61 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud