KaotoIO / kaoto

The UI of the Kaoto project
https://kaoto.io
Apache License 2.0
37 stars 29 forks source link

feat(Canvas): Show toolbar on hover #1616

Closed lordrip closed 2 weeks ago

lordrip commented 2 weeks ago
Before After
image image
Before After
image image

fix: https://github.com/KaotoIO/kaoto/issues/1580 fix: https://github.com/KaotoIO/kaoto/issues/1540

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 70.58824% with 85 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@9be2b96). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...s/Visualization/Canvas/StepToolbar/StepToolbar.tsx 20.68% 46 Missing :warning:
.../Visualization/Custom/hooks/collapse-step.hook.tsx 55.00% 8 Missing and 1 partial :warning:
...ualization/Custom/Group/CustomGroupCollapsible.tsx 41.66% 7 Missing :warning:
...ts/Visualization/Custom/hooks/insert-step.hook.tsx 63.15% 6 Missing and 1 partial :warning:
...s/Visualization/Custom/hooks/replace-step.hook.tsx 78.26% 4 Missing and 1 partial :warning:
...s/Visualization/Custom/hooks/disable-step.hook.tsx 71.42% 4 Missing :warning:
...Visualization/Custom/Group/CustomGroupExpanded.tsx 90.00% 3 Missing :warning:
...omponents/Visualization/Custom/Node/CustomNode.tsx 91.17% 3 Missing :warning:
...ponents/Visualization/Custom/Group/CustomGroup.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1616 +/- ## ======================================= Coverage ? 79.73% Complexity ? 273 ======================================= Files ? 285 Lines ? 8137 Branches ? 1590 ======================================= Hits ? 6488 Misses ? 1538 Partials ? 111 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lordrip commented 2 weeks ago

Thanks @tplevko for creating https://github.com/lordrip/kaoto/pull/37 :muscle:

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lordrip commented 2 weeks ago

@shivamG640, you might want to rebase your branch so you get the e2e fixes as well :pray: