Kareadita / Kavita

Kavita is a fast, feature rich, cross platform reading server. Built with the goal of being a full solution for all your reading needs. Setup your own server and share your reading collection with your friends and family.
http://www.kavitareader.com
GNU General Public License v3.0
6.44k stars 341 forks source link

Series with Absolute in the name being parse incorrectly #3268

Open therobbiedavis opened 1 month ago

therobbiedavis commented 1 month ago

What happened?

From Reddit: "Heya! I'm getting a small but annoying problem with DC's new Absolute line where "Absolute XXX" are identified by Kavita as "XXX." This happened with Absolute Power and now with Absolute Batman.

I'm guessing this is because the system parses "Absolute" as an absolute edition and not part of the title, but going forward I think that's gonna be a problem for a lot of people."

I believe this is happening due to the specials parser: https://github.com/Kareadita/Kavita/blob/develop/API/Services/Tasks/Scanner/Parser/Parser.cs#L672

What did you expect?

I'm not sure the best way to handle this issue, however I don't think series should be grouped if the series has a special keyword in it.

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

0.8.3 - Stable

What operating system is Kavita being hosted from?

Docker (LSIO Container)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

None

If the issue is being seen in the UI, what browsers are you seeing the problem on?

No response

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

No response

Relevant log output

No response

Additional Notes

No response

majora2007 commented 1 month ago

This is likely to be resolved when the canary changes are merged into nightly. Special keyword parsing has been removed completely from Kavita (https://github.com/Kareadita/Kavita/pull/3249).

majora2007 commented 4 weeks ago

Can I get a double check that this is now working on nightly?