KarhouTam / FL-bench

Benchmark of federated learning. Dedicated to the community. 🤗
GNU General Public License v3.0
503 stars 82 forks source link

About SCAFFOLD #3

Closed Zerek-Kel closed 1 year ago

Zerek-Kel commented 1 year ago

Thanks for your code! I want to know why the curve of SCAFFOLD on emnist behave like this? 794e9b3a-2e9b-462d-a6a7-20771c0323dd

KarhouTam commented 1 year ago

Thanks for your feedback. I fixed the SCAFFOLD codes. The collapse can be attributed to the amount of feeding data. In SCAFFOLD paper, the client feeds only one batch of data per local epoch. However, in my previous code, the client traverses the entire train set. I have checked the entire SCAFFOLD train process and can't find any problems anymore. Welcome to pull the lastest code. Here is the SCAFFOLD Learning curve over EMNIST with $Dir(1.0)$ partition: image At least it doesn't collapse anymore. 😂

Zerek-Kel commented 1 year ago

Thanks!