rewrite kohana config loading (just a bit) so it's more type-safe-ish
It's worth reading the kohana changes. Those I am most aware of. Everything else is null-checks and type hints.
There's ~1000 more phpstan errors after this. There might be a find-replace or rector rule we could nuke it with. But chances are someone will need to go fix each by hand.
Tests
Are passing - of course. That's the whole PR.
Notes
I was thinking of making this a draft and trying to resolve all the phpstan errors in one go. But I feel it's too big of a job and this PR will just get stale otherwise.
A few things here:
It's worth reading the kohana changes. Those I am most aware of. Everything else is null-checks and type hints.
There's ~1000 more phpstan errors after this. There might be a find-replace or rector rule we could nuke it with. But chances are someone will need to go fix each by hand.
Tests
Are passing - of course. That's the whole PR.
Notes
I was thinking of making this a draft and trying to resolve all the phpstan errors in one go. But I feel it's too big of a job and this PR will just get stale otherwise.
So feel free to pitch in on this one.