search

Kashif-E / CameraK

A camera library for Compose Multiplatform
MIT License
146 stars 8 forks source link

Provide Sample Layout with icons only #15

Open MathiasDL opened 1 month ago

MathiasDL commented 1 month ago

For Android and iOS, the default camera view uses icons for Capture, Flash, Back/front view.

The current sample uses Text Buttons instead. I would advise to also add a view with icons only, which you can even incorporate into the library itself as a default view. I would think most developers would go with such a default view, reducing the amount of code needed to implement this library. This has as an added bonus that you do not need to deal with localization, and you can also add a screenshot to the Readme.

Kashif-E commented 1 month ago

@MathiasDL can you share a sample? so I can understand this better an image would work

MathiasDL commented 1 month ago

See the link I posted, or a screenshot of the default camera view on my Samsung phone, relevant icons circled. As you can see, no text is required:

Screenshot_20241024_161010_Camera

Kashif-E commented 1 month ago

got ya, ill try to this asap

MathiasDL commented 1 month ago

That would be great, I did some more research into other KMP camera apps but did not find any satisfying one, so CameraK definitely has its place!

Kashif-E commented 1 month ago

thanks @MathiasDL, I really appreciate that