KatharaFramework / Kathara

A lightweight container-based network emulation system.
https://www.kathara.org/
GNU General Public License v3.0
462 stars 64 forks source link

Add `gnome-terminal` as terminal emulator #264

Closed tcaiazzi closed 8 months ago

tcaiazzi commented 10 months ago

We need to add specific support to gnome-terminal as terminal emulator.

https://github.com/KatharaFramework/Kathara/blob/d91050422e89ba89255f4330e54992377983950a/src/Kathara/cli/ui/utils.py#L91-L112

Indeed, in the unix_connect function, the -e option we use to pass the connect_command to the terminal will be deprecated for gnome-terminal in the future. We need to use -- to terminate the options and put the connect_command to execute after it.