IndexOutOfBoundsException on PaginatedIterator

Katsute commented 1 year ago

Paged responses sometimes incorrectly include a next field when there is no next page.

Hotfix would involve peeking into the next page to see if more results exist, rather than relying on the next field.

Katsute commented 1 year ago

mal forum/topic/481

ghost commented 1 year ago

https://api.myanimelist.net/v2/forum/topic/481

{
    "data": {
        "title": "Tokyo Majin Gakuen Kenpuchou Episode 2 Discussion",
        "posts": [
            {
                "id": 15582,
                "number": 1,
                "created_at": "2007-02-11T00:47:26+00:00",
                "created_by": {
                    "id": 1485,
                    "name": "manish",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/1485.gif?t=1337528400"
                },
                "body": "i liked how this episode was a flashback and how it explained some  of things from the first ep ",
                "signature": "<br />\r\n<br />\r\n<!--link--><a href=\"http://MANISH.myanimelist.net\"><img src=\"http://myanimelist.net/createimage/MANISH.png\" border=\"0\"></a>"
            },
            {
                "id": 16223,
                "number": 2,
                "created_at": "2007-02-13T03:06:19+00:00",
                "created_by": {
                    "id": 1620,
                    "name": "Taichi_EX",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/1620.png?t=1696554600"
                },
                "body": "<br />\r\nVery good episode. I liked Kyouichi and Hiyuu's fight during school.<br />\r\nWe know tha Aoi comes from a rich family and that guy with long hair has a connection with her.<br />\r\nI found it funny that both Aoi and Hiyuu received love letters, even though Hiyuu's was pretty straight foward.<br />\r\n Now we know how the main characters got those strange tattoo/symbols oon thier faces.  ",
                "signature": "[url=http://myanimelist.net/animelist/GruLen&amp;sclick=1]&lt;img src=&quot;http://myanimelist.net/signature/Taichi_EX.png&quot; border=&quot;0&quot;&gt;[/url] "
            },
            {
                "id": 16224,
                "number": 3,
                "created_at": "2007-02-13T03:22:38+00:00",
                "created_by": {
                    "id": 1653,
                    "name": "Faust721",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/1653.jpg?t=1697155500"
                },
                "body": "i thought it was a good episode as well, usually those 2nd episodes that explain the situation usually arent that good but this was an exception",
                "signature": "[url=https://myanimelist.net/animelist/Faust721&amp;sclick=1][IMG]https://hinata.taigaforum.com/sigid172157.png[/IMG][/url] "
            },
            {
                "id": 2198855,
                "number": 4,
                "created_at": "2008-12-07T03:53:40+00:00",
                "created_by": {
                    "id": 22178,
                    "name": "Crimsonwill",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/22178.jpg?t=1697102400"
                },
                "body": "I'd have to agree, ^^ it did an excellent job of recounting the events that led up to the first episode =D",
                "signature": "<!--link--><a href=\"http://myanimelist.net/animelist/Crimsonwill\"><img src=\"http://akarichan.site90.com/csig1/sig.php\" border=\"0\"></a>"
            },
            {
                "id": 4481793,
                "number": 5,
                "created_at": "2009-08-29T03:59:41+00:00",
                "created_by": {
                    "id": 146078,
                    "name": "Flaecy",
                    "forum_avator": "https://cdn.myanimelist.net//images/kaomoji_mal_white.png"
                },
                "body": "yer got rele confused on the time line.",
                "signature": "[Center][URL=https://psnprofiles.com/Flaecy][IMG]https://card.psnprofiles.com/1/Flaecy.png[/IMG][/URL][/Center]"
            },
            {
                "id": 7669736,
                "number": 6,
                "created_at": "2010-03-25T07:21:38+00:00",
                "created_by": {
                    "id": 272225,
                    "name": "hlwar",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/272225.gif?t=1497904500"
                },
                "body": "I enjoyed this episode a lot! It was very eerie, and I was actually fascinated by the Sadako-like demon that was sealed in the old Magami building. I also liked how they introduced Kisaragi. It was nice seeing him get a rather badass moment, especially when he also spread his blood on his kunai, like Kyouichi does with his bokuto. I&#039;m not entirely sure of the significance of the blood thing (although I have seen it done in other Asian programs) but I appreciate they tried to use it consistently.",
                "signature": ""
            },
            {
                "id": 7817302,
                "number": 7,
                "created_at": "2010-04-05T07:37:11+00:00",
                "created_by": {
                    "id": 9244,
                    "name": "xl3lueazndragonx",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/9244.gif?t=1680348300"
                },
                "body": "the teacher maria is hot!",
                "signature": "<!--link--><a href=\"http://myanimelist.net/mangalist/xl3lueazndragonx&amp;sclick=1\"><img src=\"http://myanimelist.net/signature/xl3lueazndragonx.png\" border=\"0\"></a> "
            },
            {
                "id": 31761147,
                "number": 8,
                "created_at": "2014-06-19T13:53:03+00:00",
                "created_by": {
                    "id": 1953548,
                    "name": "CandyRat",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/1953548.jpg?t=1697041800"
                },
                "body": "So far this looks like a pretty good anime. The time jump reminds me of Baccano!",
                "signature": "[url=https://anime.plus/CandyRat/profile][img]https://anime.plus/CandyRat/eyIwIjoxfQ/e.png[/img][/url]"
            },
            {
                "id": 32222981,
                "number": 9,
                "created_at": "2014-07-05T04:40:29+00:00",
                "created_by": {
                    "id": 280764,
                    "name": "Shocked",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/280764.jpg?t=1696813800"
                },
                "body": "Wow, the teachers in this school are pretty laid back. Still, it seems like the first episode was just the hook with the in media res stuff. Whatever works I guess.",
                "signature": "[center][img]https://i.imgur.com/lQVdcmt.png[/img][/center]<br />\r\n[center][url=http://myanimelist.net/profile/Shocked][color=#0066ff]Blog[/color][/url] | [url=http://graph.anime.plus/Shocked/profile][color=#9966ff]Profile[/color][/url] | [url=http://graph.anime.plus/Shocked/profile?referral=search][color=#6699ff]GraphAnimePlus[/color][/url][/center]"
            },
            {
                "id": 45527873,
                "number": 10,
                "created_at": "2016-04-09T01:09:02+00:00",
                "created_by": {
                    "id": 2149685,
                    "name": "Ulquiorra",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/2149685.png?t=1696813200"
                },
                "body": "That demon was creepy, too bad we didn&#039;t see her face.",
                "signature": "[center][URL=http://myanimelist.net/animelist/Ulquiorra][img]http://i.imgur.com/lja17Ys.png[/img][/URL][/center]"
            }
        ],
        "poll": {
            "id": 32,
            "question": "Tokyo Majin Gakuen Kenpuchou Episode 2 Discussion",
            "closed": false,
            "options": [
                {
                    "id": 143,
                    "text": "5 out of 5: Loved it!",
                    "votes": 15
                },
                {
                    "id": 144,
                    "text": "4 out of 5: Liked it",
                    "votes": 8
                },
                {
                    "id": 145,
                    "text": "3 out of 5: It was OK",
                    "votes": 7
                },
                {
                    "id": 146,
                    "text": "2 out of 5: Disliked it",
                    "votes": 1
                },
                {
                    "id": 147,
                    "text": "1 out of 5: Hated it",
                    "votes": 1
                }
            ]
        }
    },
    "paging": {
        "next": "https://api.myanimelist.net/v2/forum/topic/481?offset=10"
    }
}

Katsute commented 1 year ago

mal forum/topic/481?offset=10

ghost commented 1 year ago

https://api.myanimelist.net/v2/forum/topic/481?offset=10

{
    "data": {
        "title": "Tokyo Majin Gakuen Kenpuchou Episode 2 Discussion",
        "posts": [],
        "poll": {
            "id": 32,
            "question": "Tokyo Majin Gakuen Kenpuchou Episode 2 Discussion",
            "closed": false,
            "options": [
                {
                    "id": 143,
                    "text": "5 out of 5: Loved it!",
                    "votes": 15
                },
                {
                    "id": 144,
                    "text": "4 out of 5: Liked it",
                    "votes": 8
                },
                {
                    "id": 145,
                    "text": "3 out of 5: It was OK",
                    "votes": 7
                },
                {
                    "id": 146,
                    "text": "2 out of 5: Disliked it",
                    "votes": 1
                },
                {
                    "id": 147,
                    "text": "1 out of 5: Hated it",
                    "votes": 1
                }
            ]
        }
    },
    "paging": {
        "previous": "https://api.myanimelist.net/v2/forum/topic/481?offset=0"
    }
}

Katsute commented 1 year ago

mal forum/topic/481

ghost commented 1 year ago

https://api.myanimelist.net/v2/forum/topic/481

{
    "data": {
        "title": "Tokyo Majin Gakuen Kenpuchou Episode 2 Discussion",
        "posts": [
            {
                "id": 15582,
                "number": 1,
                "created_at": "2007-02-11T00:47:26+00:00",
                "created_by": {
                    "id": 1485,
                    "name": "manish",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/1485.gif?t=1337528400"
                },
                "body": "i liked how this episode was a flashback and how it explained some  of things from the first ep ",
                "signature": "<br />\r\n<br />\r\n<!--link--><a href=\"http://MANISH.myanimelist.net\"><img src=\"http://myanimelist.net/createimage/MANISH.png\" border=\"0\"></a>"
            },
            {
                "id": 16223,
                "number": 2,
                "created_at": "2007-02-13T03:06:19+00:00",
                "created_by": {
                    "id": 1620,
                    "name": "Taichi_EX",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/1620.png?t=1698104700"
                },
                "body": "<br />\r\nVery good episode. I liked Kyouichi and Hiyuu's fight during school.<br />\r\nWe know tha Aoi comes from a rich family and that guy with long hair has a connection with her.<br />\r\nI found it funny that both Aoi and Hiyuu received love letters, even though Hiyuu's was pretty straight foward.<br />\r\n Now we know how the main characters got those strange tattoo/symbols oon thier faces.  ",
                "signature": "[url=http://myanimelist.net/animelist/GruLen&amp;sclick=1]&lt;img src=&quot;http://myanimelist.net/signature/Taichi_EX.png&quot; border=&quot;0&quot;&gt;[/url] "
            },
            {
                "id": 16224,
                "number": 3,
                "created_at": "2007-02-13T03:22:38+00:00",
                "created_by": {
                    "id": 1653,
                    "name": "Faust721",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/1653.jpg?t=1698079200"
                },
                "body": "i thought it was a good episode as well, usually those 2nd episodes that explain the situation usually arent that good but this was an exception",
                "signature": "[url=https://myanimelist.net/animelist/Faust721&amp;sclick=1][IMG]https://hinata.taigaforum.com/sigid172157.png[/IMG][/url] "
            },
            {
                "id": 2198855,
                "number": 4,
                "created_at": "2008-12-07T03:53:40+00:00",
                "created_by": {
                    "id": 22178,
                    "name": "Crimsonwill",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/22178.jpg?t=1698017700"
                },
                "body": "I'd have to agree, ^^ it did an excellent job of recounting the events that led up to the first episode =D",
                "signature": "<!--link--><a href=\"http://myanimelist.net/animelist/Crimsonwill\"><img src=\"http://akarichan.site90.com/csig1/sig.php\" border=\"0\"></a>"
            },
            {
                "id": 4481793,
                "number": 5,
                "created_at": "2009-08-29T03:59:41+00:00",
                "created_by": {
                    "id": 146078,
                    "name": "Flaecy",
                    "forum_avator": "https://cdn.myanimelist.net//images/kaomoji_mal_white.png"
                },
                "body": "yer got rele confused on the time line.",
                "signature": "[Center][URL=https://psnprofiles.com/Flaecy][IMG]https://card.psnprofiles.com/1/Flaecy.png[/IMG][/URL][/Center]"
            },
            {
                "id": 7669736,
                "number": 6,
                "created_at": "2010-03-25T07:21:38+00:00",
                "created_by": {
                    "id": 272225,
                    "name": "hlwar",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/272225.gif?t=1497904500"
                },
                "body": "I enjoyed this episode a lot! It was very eerie, and I was actually fascinated by the Sadako-like demon that was sealed in the old Magami building. I also liked how they introduced Kisaragi. It was nice seeing him get a rather badass moment, especially when he also spread his blood on his kunai, like Kyouichi does with his bokuto. I&#039;m not entirely sure of the significance of the blood thing (although I have seen it done in other Asian programs) but I appreciate they tried to use it consistently.",
                "signature": ""
            },
            {
                "id": 7817302,
                "number": 7,
                "created_at": "2010-04-05T07:37:11+00:00",
                "created_by": {
                    "id": 9244,
                    "name": "xl3lueazndragonx",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/9244.gif?t=1680348300"
                },
                "body": "the teacher maria is hot!",
                "signature": "<!--link--><a href=\"http://myanimelist.net/mangalist/xl3lueazndragonx&amp;sclick=1\"><img src=\"http://myanimelist.net/signature/xl3lueazndragonx.png\" border=\"0\"></a> "
            },
            {
                "id": 31761147,
                "number": 8,
                "created_at": "2014-06-19T13:53:03+00:00",
                "created_by": {
                    "id": 1953548,
                    "name": "CandyRat",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/1953548.jpg?t=1697041800"
                },
                "body": "So far this looks like a pretty good anime. The time jump reminds me of Baccano!",
                "signature": "[url=https://anime.plus/CandyRat/profile][img]https://anime.plus/CandyRat/eyIwIjoxfQ/e.png[/img][/url]"
            },
            {
                "id": 32222981,
                "number": 9,
                "created_at": "2014-07-05T04:40:29+00:00",
                "created_by": {
                    "id": 280764,
                    "name": "Shocked",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/280764.jpg?t=1696813800"
                },
                "body": "Wow, the teachers in this school are pretty laid back. Still, it seems like the first episode was just the hook with the in media res stuff. Whatever works I guess.",
                "signature": "[center][img]https://i.imgur.com/lQVdcmt.png[/img][/center]<br />\r\n[center][url=http://myanimelist.net/profile/Shocked][color=#0066ff]Blog[/color][/url] | [url=http://graph.anime.plus/Shocked/profile][color=#9966ff]Profile[/color][/url] | [url=http://graph.anime.plus/Shocked/profile?referral=search][color=#6699ff]GraphAnimePlus[/color][/url][/center]"
            },
            {
                "id": 45527873,
                "number": 10,
                "created_at": "2016-04-09T01:09:02+00:00",
                "created_by": {
                    "id": 2149685,
                    "name": "Ulquiorra",
                    "forum_avator": "https://cdn.myanimelist.net/images/useravatars/2149685.png?t=1697844900"
                },
                "body": "That demon was creepy, too bad we didn&#039;t see her face.",
                "signature": "[center][URL=http://myanimelist.net/animelist/Ulquiorra][img]http://i.imgur.com/lja17Ys.png[/img][/URL][/center]"
            }
        ],
        "poll": {
            "id": 32,
            "question": "Tokyo Majin Gakuen Kenpuchou Episode 2 Discussion",
            "closed": false,
            "options": [
                {
                    "id": 143,
                    "text": "5 out of 5: Loved it!",
                    "votes": 15
                },
                {
                    "id": 144,
                    "text": "4 out of 5: Liked it",
                    "votes": 8
                },
                {
                    "id": 145,
                    "text": "3 out of 5: It was OK",
                    "votes": 7
                },
                {
                    "id": 146,
                    "text": "2 out of 5: Disliked it",
                    "votes": 1
                },
                {
                    "id": 147,
                    "text": "1 out of 5: Hated it",
                    "votes": 1
                }
            ]
        }
    },
    "paging": {
        "next": "https://api.myanimelist.net/v2/forum/topic/481?offset=10"
    }
}

Katsute commented 1 year ago

mal forum/topic/481?offset=10

ghost commented 1 year ago

https://api.myanimelist.net/v2/forum/topic/481?offset=10

{
    "data": {
        "title": "Tokyo Majin Gakuen Kenpuchou Episode 2 Discussion",
        "posts": [],
        "poll": {
            "id": 32,
            "question": "Tokyo Majin Gakuen Kenpuchou Episode 2 Discussion",
            "closed": false,
            "options": [
                {
                    "id": 143,
                    "text": "5 out of 5: Loved it!",
                    "votes": 15
                },
                {
                    "id": 144,
                    "text": "4 out of 5: Liked it",
                    "votes": 8
                },
                {
                    "id": 145,
                    "text": "3 out of 5: It was OK",
                    "votes": 7
                },
                {
                    "id": 146,
                    "text": "2 out of 5: Disliked it",
                    "votes": 1
                },
                {
                    "id": 147,
                    "text": "1 out of 5: Hated it",
                    "votes": 1
                }
            ]
        }
    },
    "paging": {
        "previous": "https://api.myanimelist.net/v2/forum/topic/481?offset=0"
    }
}

Katsute commented 11 months ago

This issue is caused by the forum update.

See https://myanimelist.net/forum/?topicid=2132783

KatsuteDev / Mal4J

IndexOutOfBoundsException on PaginatedIterator #404