Caps crashes [NoScript]

[GoogleCodeExporter]

This is a tracking bug spun out of issue 47 since this keeps cropping up.
Caps was supposed to be fixed by 217967 and 300853 but isn't getting fixed,
so I'm adding more and more guard code. Generally this is triggered by
toggling on and off NoScript as you enter and leave sites, and I want to
*encourage* this behaviour while JavaScript is still technically unsafe, so
we need to make sure this doesn't bite people.

The main problem is invalid policies of some kind getting passed off to
XPCOM, which then dereferences the bogus pointers within and bombs.

I'm going to leave this tracker open until I've thrashed it sufficiently.
Added some more code tonight and we will see.

Original issue reported on code.google.com by classi...@floodgap.com on 10 Sep 2009 at 5:41

[GoogleCodeExporter]

Another Caps crash. It seems that cached policies are also getting silently
invalidated. Removed the code to do policy caching. This is a perf hit, but not 
a big
one.

Original comment by classi...@floodgap.com on 11 Sep 2009 at 4:54

[GoogleCodeExporter]

Bug 217967 introduced a regression which I fixed where sites would be blocked 
even if
they were enabled, which I had not noticed earlier because I am surfing on 
purpose
with JS enabled on all sites. Part of this bug, which admittedly was for 1.4, is
backed out now. Disabling cached policies appears to have been the major part of
solving this bug, as to date there have been no more caps crashes otherwise.

Original comment by classi...@floodgap.com on 18 Sep 2009 at 4:21

[GoogleCodeExporter]

Since 9.0.4 is shipping and I have observed no more crashes, closing this bug. 
Yay!

Original comment by classi...@floodgap.com on 23 Oct 2009 at 3:51

• Changed state: Verified