search

Keats / validator

Simple validation for Rust structs
MIT License
2.07k stars 151 forks source link

Swap to Proc Macro Error 2 RUSTSEC-2024-0370 #350

Closed pvichivanives closed 4 weeks ago

pvichivanives commented 2 months ago

Hi! Given the RUSTSEC warning issued here: https://rustsec.org/advisories/RUSTSEC-2024-0370 just submitting a PR to move to the reccomended new version of procmacroerror2 image

Closes https://github.com/Keats/validator/issues/351

jayvdb commented 2 months ago

Please run the tests with TRYBUILD=overwrite set.

jayvdb commented 2 months ago

ping @Keats

pvichivanives commented 2 months ago

Apparently the error messages between 1.79 and 1.81 are different. I've pushed the error messages for 1.79 since it seems thats what the CI test was failing on fist. However, one will always fail. This is true on the master branch as well.

pvichivanives commented 1 month ago

Interesting, its definitely all passing locally for me except for the error message issue that I mentioned earlier. IS CI turning all feature flags to true?

Keats commented 1 month ago

It does: https://github.com/Keats/validator/blob/master/.github/workflows/ci.yml#L25-L28

pvichivanives commented 1 month ago

TY! Haven't used the github workflow before so didn't know ci was there. Updated it to only run all the feature flags. Still that issue though of the TRYBUILD=overwrite set where rn its set to 1.70. I can set it to 1.81 as well but that then we would fail. The wording was changed in 1.81. So I also bumped the tests MSRV to 1.81 but I can rever that commit if not desired.

Keats commented 1 month ago

That looks ok to me. Ok for everyone else as well?

pvichivanives commented 1 month ago

Wanted to note that we have an issue with Workflow though in that Nightly uses different highlighting to stable. This is expected since we are enabling the NIGHTLY warnings. Going to see if I can fix that later in another PR but for now I have try-build fail disabled with all-features image

Keats commented 1 month ago

Maybe just try to build in CI using nightly rather than run the test?

pvichivanives commented 1 month ago

Happy to just build in CI too, I thought it might be more useful if we at least run all the tests we can though.