search

Kebechet / Maui.RevenueCat.InAppBilling

MIT License
12 stars 6 forks source link

Add option to configure AppUserId from Initialize #40

Closed MoienTajik closed 2 months ago

MoienTajik commented 2 months ago

Currently Initialize method in RevenueCatBillingiOS (I'm not sure about Android impl detail) doesn't accept AppUserId, but Purchases.ConfigureWithAPIKey accepts that parameter and we can initialize the AppUserId from startup instead of doing that via Login.

Kebechet commented 2 months ago

So If I understand this correctly you would like to have 2 methods: current one: Initialize(string apiKey) and new one: Initialize(string apiKey, string appUserId)

Correct ?

MoienTajik commented 2 months ago

Yes, exactly. This way, we can initialize the plugin using appUserId in first place in the DI, and as far as I understood, that doesn't need to be async unlike the Login method.

Kebechet commented 2 months ago

This month I am quite busy so I wont be able to implement this. But feel free to create a PR

Kebechet commented 2 months ago

Ok I got to that sooner because I needed to adjust something else as well.

Your proposal was Implemented in: https://github.com/Kebechet/Maui.RevenueCat.InAppBilling/commit/772a40375b011c884ea0940c3c9262cf4d23db95

and will be released as v4.5.0

Please test it and then let me know

Kebechet commented 2 months ago

@MoienTajik does it work correctly ?

MoienTajik commented 1 month ago

Yes, Thanks! @Kebechet