KejPi / AbracaDABra

Abraca DAB radio: DAB/DAB+ Software Defined Radio (SDR)
MIT License
68 stars 8 forks source link

Service list not reliably playing the selected station #58

Closed andimik closed 1 year ago

andimik commented 1 year ago

Sometimes a click on a favorite station will not play it, but the previous heard station.

grafik

Seems this only is in combination with a station on two muxes or channels.

I tried to find the steps how to re-produce it, but I couldn't find a way for describing that 100% accurate.

KejPi commented 1 year ago

I do not have this experience on Mac/Windows with the ensembles I have on my antenna. Waiting for steps to reproduce.

andimik commented 1 year ago

I had this behaviour 7 times up to now. But not 100% accurate steps. Selecting favorite and non-favorite and toggling.

grafik

KejPi commented 1 year ago

Is it really only favorite - non favorite toggling? Have you tried 2 favorites or 2 non-favorites? There should be no difference between favorite and others, it is only different way to display service list item.

andimik commented 1 year ago

Bingo, also non-favorite are affected.

Was toggling between 2 non-favorite stations, in this case entry 2 and 3 ('WELLE 1 and * 88.6 *)

grafik

andimik commented 1 year ago

Not related to Austrian muxes ...

grafik

Hint: I'm clicking on the entry in the middle, not on the right.

KejPi commented 1 year ago

Interesting, I am not able to reproduce it on Mac. When this happens - is it the service displayed on top playing it does the service selected in the service list play? And can you confirm the problem with a service that is coming from 1 ensemble? In your case both services are coming from 2 ensembles.

andimik commented 1 year ago

Another attempt. Delete all entries. Only lock both Slovenian muxes R2West and R2East.

Radio Antena and Bob are in both muxes.

Switching between Antena (on 2 muxes) an Aktual Kum (only on 1 mux). Sometimes pressing the toggling muxes icon.

grafik

You will hear the sound of the station displayed on the left (in this case Antena)

BUT the toggling function will NOT work here as the marked (!) service (in this case Aktual Kum) does NOT have a 2nd.

I guess the second (!!) toggling produces this error.

andimik commented 1 year ago

This is a video:

Bildschirmaufzeichnung vom 27.02.2023, 22:41:46.webm

andimik commented 1 year ago

Now with the cursor including empty service list and re-scan.

Bildschirmaufzeichnung vom 27.02.2023, 22:47:18.webm

KejPi commented 1 year ago

Thank for the video, it helped me to reproduce the behavior 👍 Just to be clear - was the issue always related to switching of the service source (button on top) or simple clicking in the service list did that too?

EDIT: I can answer myself, yes it happens too, I already know how to reproduce the problem without using source select and have an idea where it is coming from, it is timing problem.

andimik commented 1 year ago

Yes, I already thought about that. If you compare how long locking is taking, then you understand it.

KejPi commented 1 year ago

Steps to reproduce are actually very simple. Just 2 ensembles are needed:

  1. Select any service in ensA
  2. Wait until it is tuned
  3. Select service1 in ensB
  4. Immediately when UI allows you select another service2 in ensB

As a result, service1 is playing but service2 is selected in service list.

This way I can reproduce the issue in 100% cases, I hope it is the same issue that you have reported originally.

andimik commented 1 year ago

In the next days I am not at home to test it.

Oh, even easier...

But I think the root cause is the same (timing).

andimik commented 1 year ago

ok, seems to be fixed with that commit, therefore, I'll close it.