KerbalKore / CWPT

Cold War Progression
GNU General Public License v3.0
1 stars 4 forks source link

Delta #15

Closed KerbalKore closed 4 years ago

KerbalKore commented 4 years ago

GEMs

zorg2044 commented 4 years ago

Just a heads up the RS27A subtype is not linked to an upgrade. Its just there as a switch. The subtype was created for accuracy but there is no upgrade linked since the RS27A trades higher Isp and thrust for lower sea level Isp. So it isnt a straight up upgrade in all respects. It in fact has less thrust at sea level than the RS27 (by a small but noticeable amount).

If you wanted to place it somewhere specific you would need to patch in an upgrade into the subtype node or something.

KerbalKore commented 4 years ago

Thanks for the tip! Based on what I found online, the RS27A was used on Delta from 7000 up, while the normal RS27 was used on Delta on 2000, 3000, and 5000. image Since we're going to need more Delta nodes anyway, I figure we can make an upgrade to unlock the RS27A in delta7k.

KerbalKore commented 4 years ago

@zorg2044 would this work to make the RS27A subtype require an upgrade?

%PARTUPGRADE[bluedog_delta]:FIRST:NEEDS[Bluedog_DB]
{
  name = bluedog_RS27A // RS27A
    partIcon = bluedog.Delta2.RS27
    techRequired = delta7k
    entryCost = 5000
    cost = 0 // for display only; all parts implementing this will need a PartStatsUpgradeModule with cost = this.

    title = Daleth-SSR-27a "Darkah" Liquid Engine
    basicInfo = <color=green>Max. Thrust (Vac.): 263.5 kN\nEngine Isp: 302 (Vac.)</color>
    manufacturer = Bluedog Design Bureau
    description = Upgrades the Daleth-SSR-27 "Darkah" Liquid Engine to the SSR-27A model.
}
@PART[bluedog_Delta2_RS27]:After[Bluedog_DB]
{
        @MODULE[ModuleB9PartSwitch]
        {
                @SUBTYPE[name[RS27A]]
                {
                 %upgradeRequired = bluedog_RS27A
                }
    }
}
DeltaDizzy commented 4 years ago

@KerbalKore so you are editing a PARTUPGRADE named bluedog_delta, and INSERTING a name key with value bluedog_RS27A

KerbalKore commented 4 years ago

yeah hold on I did a goof

KerbalKore commented 4 years ago
+PARTUPGRADE:FIRST:NEEDS[Bluedog_DB]
{
  name = bluedog_RS27A // RS27A
    partIcon = bluedog.Delta2.RS27
    techRequired = delta7k
    entryCost = 5000
    cost = 0 // for display only; all parts implementing this will need a PartStatsUpgradeModule with cost = this.

    title = Daleth-SSR-27a "Darkah" Liquid Engine
    basicInfo = <color=green>Max. Thrust (Vac.): 263.5 kN\nEngine Isp: 302 (Vac.)</color>
    manufacturer = Bluedog Design Bureau
    description = Upgrades the Daleth-SSR-27 "Darkah" Liquid Engine to the SSR-27A model.
}
@PART[bluedog_Delta2_RS27]:After[Bluedog_DB]
{
        @MODULE[ModuleB9PartSwitch]
        {
                @SUBTYPE[name[RS27A]]
                {
                 %upgradeRequired = bluedog_RS27A
                }
    }
}

would this work @DeltaDizzy @zorg2044 ?

DeltaDizzy commented 4 years ago

@KerbalKore which PARTUPGRADE are you copying?

KerbalKore commented 4 years ago

@DeltaDizzy I'm in class RN so i cant talk on discord, but im trying to make a new upgrade, and then make it so that the RS27A subtype requires that upgrade

zorg2044 commented 4 years ago

It might work for the Rs27 but in general its a good idea to specify the module ID for B9 since a lot of parts might have multiple B9 switchers. It also makes your patch resilient against other types of B9 switchers being added to the part after the fact.

@PART[bluedog_Delta2_RS27]:After[Bluedog_DB]
{
        @MODULE[ModuleB9PartSwitch]:HAS[#moduleID[engineSwitch]]
        {
              ---snip---
    }
}
DeltaDizzy commented 4 years ago

Is it the GEM-60XL or the GEM-63XL?